This repository was archived by the owner on Sep 11, 2025. It is now read-only.
fix: check for nil sentry client #937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a guard to avoid nil pointer dereferences when the Sentry client is not initialized in the CaptureError and CaptureWarning functions.
- Cache the result of
hub.Client()in a local variable and check for nil before proceeding - Replace repeated
hub.Client()calls with the cachedclient - Early return if
clientis nil
Comments suppressed due to low confidence (2)
runtime/sentryutils/sentry.go:212
- Add tests covering the scenario where
hub.Client()returns nil for bothCaptureErrorandCaptureWarningto ensure these functions exit cleanly without panicking.
client := hub.Client()
runtime/sentryutils/sentry.go:210
- [nitpick] Update the function comment to note that
CaptureErrorwill return early if the Sentry client is nil, clarifying this behavior for future readers.
func CaptureError(ctx context.Context, err error, msg string, opts ...func(event *sentry.Event)) {
Comment on lines
211
to
+212
| hub := ActiveHub(ctx) | ||
| client := hub.Client() |
There was a problem hiding this comment.
[nitpick] Consider extracting the client retrieval and nil-check into a helper function to avoid duplicating this pattern in both CaptureError and CaptureWarning.
Suggested change
| hub := ActiveHub(ctx) | |
| client := hub.Client() | |
| client := getClient(ctx) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
small update to #931