This repository was archived by the owner on Sep 11, 2025. It is now read-only.
fix: write inference history directly #938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the previous batching worker for inference history and switches to immediate writes, refactors database writer functions, standardizes the ModusDB engine variable naming, and updates the changelog.
- Drop batching logic and write inference history directly to the database
- Rename
GlobalModusDbEnginetoglobalModusDbEngineand update usages - Split and refactor write routines for ModusDB and Postgres, and revise
WritePluginInfo
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| runtime/metrics/metrics.go | Removed DroppedInferencesNum metric registration |
| runtime/db/modusdb.go | Lowercased globalModusDbEngine variable and updated references |
| runtime/db/inferencehistory.go | Eliminated batch writer; inlined direct DB writes; refactored write functions |
| runtime/db/db.go | Removed background worker, simplified pool init with getPool |
| runtime/db/agentstate.go | Updated ModusDB engine references to globalModusDbEngine |
| CHANGELOG.md | Added fix: write inference history directly [#938] |
Comments suppressed due to low confidence (3)
runtime/db/inferencehistory.go:306
- There are no unit tests covering
writeInferenceHistoryToPostgresDB. Adding targeted tests can help ensure correct SQL generation and error handling.
func writeInferenceHistoryToPostgresDB(ctx context.Context, data inferenceHistory) error {
runtime/db/inferencehistory.go:151
- Consider adding tests for
writePluginInfoToModusDBto verify that plugin metadata is correctly serialized and errors are handled gracefully.
func writePluginInfoToModusDB(ctx context.Context, plugin *plugins.Plugin) error {
runtime/db/inferencehistory.go:235
- Switching from batched, asynchronous writes to synchronous writes on each inference may introduce latency under high load. Consider benchmarking the impact or reintroducing a bounded batch or queue to smooth out spikes.
func WriteInferenceHistory(ctx context.Context, model *manifest.ModelInfo, input, output any, start, end time.Time) {
mattjohnsonpint
deleted the
mjp/mod-9-invalid-json-data-when-saving-inference-history
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #927. The issue was related to the batch not being thread safe, and having multiple triggers that could happen concurrently.