Improve sentry reporting

Author: bcomnes

CHANGELOG.md

@@ -2,6 +2,10 @@
 All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 
+## 0.5.6 - 2017-11-11
+* Report auto update errors to sentry
+* Switch to a shared thread sentry for easier importing to unrelated modules
+
 ## 0.5.5 - 2017-11-11
 * Add sentry
 * Expose auto-update events to player

main/index.js

@@ -1,6 +1,7 @@
 var isDev = require('electron-is-dev')
+var sentry
 if (!isDev) {
-  require('../sentry')('main')
+  sentry = require('../sentry')
 }
 var { app, ipcMain } = require('electron')
 var Config = require('electron-store')
@@ -246,8 +247,8 @@ app.on('ready', function appReady () {
   }
 
   autoUpdater.on('error', (err) => {
-    console.log(err)
     broadcast('au:error', err)
+    if (sentry) sentry.captureException(err)
   })
 
   autoUpdater.on('checking-for-update', () => {

renderer/audio.html

@@ -13,7 +13,7 @@ <h1>🎵</h1>
   <audio id="needle"></audio>
   <script>
     var isDev = require('electron-is-dev')
-    if (!isDev) require('../sentry.js')('audio')
+    if (!isDev) require('../sentry.js')
     require('./audio/index.js')
   </script>
 </body>

renderer/index.html

@@ -8,7 +8,7 @@
   <main id="app"></main>
   <script>
     var isDev = require('electron-is-dev')
-    if (!isDev) window.raven = require('../sentry.js')('player')
+    if (!isDev) window.raven = require('../sentry.js')
     if (isDev || process.env.DEV_SERVER) {
       var bundle = document.createElement('script')
       bundle.src = 'http://localhost:9966/bundle.js'

sentry.js

@@ -8,10 +8,10 @@ var RAVEN_C = '243594'
 var MAIN_THREAD = 'browser'
 var RENDERER = 'renderer'
 
-function getopts (processtype, name) {
+function getopts (processtype) {
   return {
     captureUnhandledRejections: true,
-    name: name || 'Hyperamp',
+    name: 'Hyperamp',
     release: require('./package.json').version,
     extra: {
       platform: os.platform(),
@@ -26,37 +26,34 @@ function getopts (processtype, name) {
   }
 }
 
-function setup (name) {
-  // process.type === 'browser' : main thread
-  // process.type === 'renderer' : electron window
-  var raven = process.type === MAIN_THREAD ? require('raven') : require('raven-js')
-  var url = process.type === MAIN_THREAD ? `https://${RAVEN_A}:${RAVEN_B}@sentry.io/${RAVEN_C}` : `https://${RAVEN_A}@sentry.io/${RAVEN_C}`
+// process.type === 'browser' : main thread
+// process.type === 'renderer' : electron window
+var raven = process.type === MAIN_THREAD ? require('raven') : require('raven-js')
+var url = process.type === MAIN_THREAD ? `https://${RAVEN_A}:${RAVEN_B}@sentry.io/${RAVEN_C}` : `https://${RAVEN_A}@sentry.io/${RAVEN_C}`
 
-  if (process.type === MAIN_THREAD) {
+if (process.type === MAIN_THREAD) {
     // Main thread stuff only
-    process.on('uncaughtException', (err) => {
-      const dialog = require('electron').dialog
+  process.on('uncaughtException', (err) => {
+    const dialog = require('electron').dialog
 
-      dialog.showMessageBox({
-        title: 'An error occurred',
-        message: `Sorry for the trouble, but an error has occurred in Hyperamp and we don't know how to recover from it.
+    dialog.showMessageBox({
+      title: 'An error occurred',
+      message: `Sorry for the trouble, but an error has occurred in Hyperamp and we don't know how to recover from it.
 
 If you are connected to the internet, this has been reported anonymously to the project maintainers - they will work on a fix.
 
 The app may now quit - you can safely reopen it.`,
-        detail: err.stack,
-        buttons: ['OK']
-      })
+      detail: err.stack,
+      buttons: ['OK']
     })
-  }
+  })
+}
 
-  if (process.type === RENDERER) {
+if (process.type === RENDERER) {
     // Renderer stuff only
-  }
-
-  var sentry = raven.config(url, getopts(process.type), name).install()
-  console.log('Sentry installed')
-  return sentry
 }
 
-module.exports = setup
+var sentry = raven.config(url, getopts(process.type)).install()
+console.log('Sentry installed')
+
+module.exports = sentry