Skip to content

Commit 1c0e873

Browse files
committed
Fix typos in README and remove commented code
1 parent d1faa04 commit 1c0e873

File tree

3 files changed

+4
-18
lines changed

3 files changed

+4
-18
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -318,7 +318,7 @@ removed automatically when the weekly captured observer has been deallocated.
318318

319319
```swift
320320
// Add observer
321-
let token = storage.addStorageObserver(self) { observer, storage, change
321+
let token = storage.addStorageObserver(self) { observer, storage, change in
322322
switch change {
323323
case .add(let key):
324324
print("Added \(key)")
@@ -356,7 +356,7 @@ let token = storage.addObserver(self, forKey: key) { observer, storage, change i
356356
token.cancel()
357357

358358
// Remove observer for key
359-
storage.removeObserver(forKey: "user1")
359+
storage.removeObserver(forKey: key)
360360

361361
// Remove all observers
362362
storage.removeAllKeyObservers()

Source/Shared/Storage/HybridStorage.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ public final class HybridStorage<T> {
55
public let memoryStorage: MemoryStorage<T>
66
public let diskStorage: DiskStorage<T>
77

8-
private(set) var storageObservations = [UUID : (HybridStorage, StorageChange) -> Void]()
9-
private(set) var keyObservations = [String : (HybridStorage, KeyChange<T>) -> Void]()
8+
private(set) var storageObservations = [UUID: (HybridStorage, StorageChange) -> Void]()
9+
private(set) var keyObservations = [String: (HybridStorage, KeyChange<T>) -> Void]()
1010

1111
public init(memoryStorage: MemoryStorage<T>, diskStorage: DiskStorage<T>) {
1212
self.memoryStorage = memoryStorage

Source/Shared/Storage/Storage.swift

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -36,24 +36,10 @@ public final class Storage<T> {
3636
storage: hybridStorage,
3737
serialQueue: DispatchQueue(label: "Cache.AsyncStorage.SerialQueue")
3838
)
39-
subscribeToChanges(in: hybridStorage)
4039
}
4140

4241
/// Used for async operations
4342
public lazy var async = self.asyncStorage
44-
45-
private func subscribeToChanges(in storage: HybridStorage<T>) {
46-
// storage.storageObservationRegistry.addObservation { [weak self] _, change in
47-
// guard let strongSelf = self else { return }
48-
// strongSelf.storageObservationRegistry.notifyObservers(about: change, in: strongSelf)
49-
// }
50-
// keyObservationRegistry.onNewKey = { [weak self] key in
51-
// guard let strongSelf = self else { return }
52-
// storage.keyObservationRegistry.addObservation({ _, change in
53-
// strongSelf.keyObservationRegistry.notifyObserver(forKey: key, about: change, in: strongSelf)
54-
// }, forKey: key)
55-
// }
56-
}
5743
}
5844

5945
extension Storage: StorageAware {

0 commit comments

Comments
 (0)