Skip to content

Commit 12b1b33

Browse files
committed
Merge pull request #7 from hyperoslo/improve/drop-self
Drop use of self
2 parents 6621219 + 5535524 commit 12b1b33

File tree

3 files changed

+35
-37
lines changed

3 files changed

+35
-37
lines changed

Pod/PagesDemo/AppDelegate.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,9 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
4343
target: pages,
4444
action: "next")
4545

46-
self.window = UIWindow(frame: UIScreen.mainScreen().bounds)
47-
self.window?.rootViewController = navigationController
48-
self.window?.makeKeyAndVisible()
46+
window = UIWindow(frame: UIScreen.mainScreen().bounds)
47+
window?.rootViewController = navigationController
48+
window?.makeKeyAndVisible()
4949

5050
return true
5151
}

Pod/Pod.xcodeproj/project.pbxproj

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
14C136521AB784B200B7B07A /* CONTRIBUTING.md */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = net.daringfireball.markdown; name = CONTRIBUTING.md; path = ../CONTRIBUTING.md; sourceTree = "<group>"; };
2020
14C136541AB784B200B7B07A /* LICENSE.md */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = net.daringfireball.markdown; name = LICENSE.md; path = ../LICENSE.md; sourceTree = "<group>"; };
2121
14C136551AB784B200B7B07A /* README.md */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = net.daringfireball.markdown; name = README.md; path = ../README.md; sourceTree = "<group>"; };
22-
14C1365C1AB784BC00B7B07A /* .gitkeep */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = .gitkeep; sourceTree = "<group>"; };
2322
BDA157F21AD7E6D90011D55A /* PagesTests.xctest */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = PagesTests.xctest; sourceTree = BUILT_PRODUCTS_DIR; };
2423
BDA157F51AD7E6D90011D55A /* Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = "<group>"; };
2524
BDA157F61AD7E6D90011D55A /* PagesTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = PagesTests.swift; sourceTree = "<group>"; };
@@ -84,7 +83,6 @@
8483
14C1365B1AB784BC00B7B07A /* Source */ = {
8584
isa = PBXGroup;
8685
children = (
87-
14C1365C1AB784BC00B7B07A /* .gitkeep */,
8886
BDA157FB1AD7E6FF0011D55A /* PagesController.swift */,
8987
);
9088
name = Source;

Source/PagesController.swift

Lines changed: 32 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import UIKit
77

88
public var enableSwipe = true {
99
didSet {
10-
self.toggle()
10+
toggle()
1111
}
1212
}
1313

@@ -23,45 +23,45 @@ import UIKit
2323
navigationOrientation: navigationOrientation,
2424
options: options)
2525

26-
self.add(pages)
26+
add(pages)
2727
}
2828

2929
public override func viewDidLoad() {
3030
super.viewDidLoad()
3131

32-
self.delegate = self
33-
self.dataSource = self
34-
self.goto(self.startPage)
32+
delegate = self
33+
dataSource = self
34+
goto(startPage)
3535
}
3636
}
3737

3838
// MARK: Public methods
3939
extension PagesController {
4040

4141
public func goto(index: Int) {
42-
if index > -1 && index < self.pages.count {
43-
let viewController = self.pages[index]
44-
self.currentIndex = index
45-
self.setViewControllers([viewController],
46-
direction: (index > self.currentIndex) ? .Forward : .Reverse,
42+
if index > -1 && index < pages.count {
43+
let viewController = pages[index]
44+
currentIndex = index
45+
setViewControllers([viewController],
46+
direction: (index > currentIndex) ? .Forward : .Reverse,
4747
animated: true, completion: nil)
48-
if self.setNavigationTitle {
49-
self.title = viewController.title
48+
if setNavigationTitle {
49+
title = viewController.title
5050
}
5151
}
5252
}
5353

5454
public func next() {
55-
self.goto(self.currentIndex + 1)
55+
goto(currentIndex + 1)
5656
}
5757

5858
public func previous() {
59-
self.goto(self.currentIndex - 1)
59+
goto(currentIndex - 1)
6060
}
6161

6262
public func add(viewControllers: [UIViewController]) {
6363
for viewController in viewControllers {
64-
self.addViewController(viewController)
64+
addViewController(viewController)
6565
}
6666
}
6767
}
@@ -72,20 +72,20 @@ extension PagesController {
7272

7373
public func pageViewController(pageViewController: UIPageViewController, viewControllerBeforeViewController viewController: UIViewController) -> UIViewController? {
7474
let index = prevIndex(viewControllerIndex(viewController))
75-
return self.pages.at(index)
75+
return pages.at(index)
7676
}
7777

7878
public func pageViewController(pageViewController: UIPageViewController, viewControllerAfterViewController viewController: UIViewController) -> UIViewController? {
7979
let index: Int? = nextIndex(viewControllerIndex(viewController))
80-
return self.pages.at(index)
80+
return pages.at(index)
8181
}
8282

8383
public func presentationCountForPageViewController(pageViewController: UIPageViewController) -> Int {
84-
return self.pages.count
84+
return pages.count
8585
}
8686

8787
public func presentationIndexForPageViewController(pageViewController: UIPageViewController) -> Int {
88-
return self.currentIndex
88+
return currentIndex
8989
}
9090

9191
}
@@ -97,11 +97,11 @@ extension PagesController {
9797
public func pageViewController(pageViewController: UIPageViewController, willTransitionToViewControllers pendingViewControllers: [AnyObject]) {
9898

9999
if let viewController = pendingViewControllers.first as? UIViewController,
100-
index = self.viewControllerIndex(viewController) {
101-
self.currentIndex = index
100+
index = viewControllerIndex(viewController) {
101+
currentIndex = index
102102

103-
if self.setNavigationTitle {
104-
self.title = viewController.title
103+
if setNavigationTitle {
104+
title = viewController.title
105105
}
106106
}
107107
}
@@ -113,25 +113,25 @@ extension PagesController {
113113
extension PagesController {
114114

115115
func viewControllerIndex(viewController: UIViewController) -> Int? {
116-
return find(self.pages, viewController)
116+
return find(pages, viewController)
117117
}
118118

119119
private func toggle() {
120-
for recognizer in self.gestureRecognizers {
121-
(recognizer as! UIGestureRecognizer).enabled = self.enableSwipe
120+
for recognizer in gestureRecognizers {
121+
(recognizer as! UIGestureRecognizer).enabled = enableSwipe
122122
}
123123
}
124124

125125
private func addViewController(viewController: UIViewController) {
126-
self.pages.append(viewController)
126+
pages.append(viewController)
127127

128-
if self.pages.count == 1 {
129-
self.setViewControllers([viewController],
128+
if pages.count == 1 {
129+
setViewControllers([viewController],
130130
direction: .Forward,
131131
animated: true,
132132
completion: nil)
133-
if self.setNavigationTitle {
134-
self.title = viewController.title
133+
if setNavigationTitle {
134+
title = viewController.title
135135
}
136136
}
137137
}
@@ -140,7 +140,7 @@ extension PagesController {
140140
extension Array {
141141

142142
func at(index: Int?) -> T? {
143-
if let index = index where index >= 0 && index < self.endIndex {
143+
if let index = index where index >= 0 && index < endIndex {
144144
return self[index]
145145
} else {
146146
return nil

0 commit comments

Comments
 (0)