misc fixes

Author: catmando

ruby/hyper-model/lib/reactive_record/active_record/associations.rb

@@ -163,7 +163,7 @@ def find_inverse(model)  # private
         the_klass.reflect_on_all_associations.each do |association|
           next if association.association_foreign_key != @association_foreign_key
           next if association.attribute == attribute
-          return association if the_klass == association.owner_class
+          return association if association.polymorphic? || association.klass == owner_class
         end
         raise "could not find inverse of polymorphic belongs_to: #{model.inspect} #{self.inspect}" if options[:polymorphic]
         # instead of raising an error go ahead and create the inverse relationship if it does not exist.

ruby/hyper-model/lib/reactive_record/active_record/class_methods.rb

@@ -172,7 +172,7 @@ def alias_attribute(new_name, old_name)
       :full_table_name_prefix, :full_table_name_suffix, :reset_sequence_name, :sequence_name=, :next_sequence_value, :column_defaults, :content_columns,
       :readonly_attributes, :attr_readonly, :create, :create!, :instantiate, :find, :type_caster, :arel_table, :find_by, :find_by!, :initialize_find_by_cache,
       :generated_association_methods, :arel_engine, :arel_attribute, :predicate_builder, :collection_cache_key, :relation_delegate_class,
-      :initialize_relation_delegate_cache, :enum, :collecting_queries_for_explain, :exec_explain, :i18n_scope, :lookup_ancestors, :human_attribute_name,
+      :initialize_relation_delegate_cache, :enum, :collecting_queries_for_explain, :exec_explain, :i18n_scope, :lookup_ancestors,
       :references, :uniq, :maximum, :none, :exists?, :second, :limit, :order, :eager_load, :update, :delete_all, :destroy, :ids, :many?, :pluck, :third,
       :delete, :fourth, :fifth, :forty_two, :second_to_last, :third_to_last, :preload, :sum, :take!, :first!, :last!, :second!, :offset, :select, :fourth!,
       :third!, :third_to_last!, :fifth!, :where, :first_or_create, :second_to_last!, :forty_two!, :first, :having, :any?, :one?, :none?, :find_or_create_by,
@@ -336,6 +336,10 @@ def server_method(name, default: nil)
       end
     end
 
+    def human_attribute_name(attribute, opts = {})
+      opts[:default] || attribute
+    end
+
     def define_attribute_methods
       columns_hash.each do |name, column_hash|
         next if name == primary_key

ruby/hyper-model/lib/reactive_record/active_record/reactive_record/base.rb

@@ -207,7 +207,7 @@ def changes
     end
 
     def errors
-      @errors ||= ActiveModel::Errors.new(self)
+      @errors ||= ActiveModel::Errors.new(ar_instance)
     end
 
     # called when we have a newly created record, to initialize

ruby/hyper-model/lib/reactive_record/active_record/reactive_record/collection.rb

@@ -435,8 +435,9 @@ def update_child(item)
         inverse_of = @association.inverse_of
         current_association_value = item.attributes[inverse_of]
         backing_record.virgin = false unless backing_record.data_loading?
-        #backing_record.update_belongs_to(inverse_of, @owner)
-        backing_record.set_belongs_to_via_has_many(@association, @owner)
+        # next line was commented out and following line was active.
+        backing_record.update_belongs_to(inverse_of, @owner)
+        #backing_record.set_belongs_to_via_has_many(@association, @owner)
         # following is handled by update_belongs_to and is redundant
         # unless current_association_value.nil?  # might be a dummy value which responds to nil
         #   current_association = @association.inverse.inverse(current_association_value)
@@ -542,8 +543,8 @@ def internal_replace(new_array)
           r.id = new_array[i].id if array[i] and array[i].id and !r.new? and r.backing_record.vector.last =~ /^\*[0-9]+$/
         end
       end
-
-      @collection.dup.each { |item| delete(item) } if @collection  # this line is a big nop I think
+      # the following makes sure that the existing elements are properly removed from the collection
+      @collection.dup.each { |item| delete(item) } if @collection
       @collection = []
       if new_array.is_a? Collection
         @dummy_collection = new_array.dummy_collection

ruby/hyper-model/lib/reactive_record/active_record/reactive_record/getters.rb

@@ -108,7 +108,7 @@ def getter_common(attribute, reload)
       else
         virtual_fetch_on_server_warning(attribute) if on_opal_server? && changed?
         yield false, attribute
-      end.tap { |value| Hyperstack::Internal::State::Variable.get(self, attribute) unless data_loading? }
+      end.tap { Hyperstack::Internal::State::Variable.get(self, attribute) unless data_loading? }
     end
 
     def find_association(association, id, klass)

ruby/hyper-model/spec/batch1/misc/validate_spec.rb

@@ -42,6 +42,14 @@
     end.to eq("last_name"=>["no swear words allowed"])
   end
 
+  it "can validate and use the full_messages method" do
+    expect_promise do
+      User.new(last_name: 'f**k').validate.then do |new_user|
+        new_user.errors.full_messages
+      end
+    end.to eq(["Last name no swear words allowed"])
+  end
+
   it "the valid? method will return true if the model has no errors" do
     mount "Validator" do
       class Validator < HyperComponent
@@ -62,8 +70,9 @@ class << self
   it "the valid? method will return false if the model has errors" do
     expect_promise do
       user = User.new(last_name: 'f**k')
-      user.save.then { user.valid? }
+      user.save(validate: true).then { |result| user.valid?}
     end.to be_falsy
+
   end
 
   it "the valid? method reacts to the model being saved" do