Disable/enable instrumentations

[pavolloffay]

Auto instrumentation can sometimes cause issues. Therefore having a config to disable a specific framework(s) is very useful.

I need this config for the Javaagent but I anticipate it might be useful for other agents as well. In java agent a framework instrumentation can be disabled by -Dotel.instrumentation.aws-sdk.enabled=false".

I propose to add top level config

message AgentConfig {
 map<string, boolean> instrumentation = 3;
}

The boolean because in some cases an agent might ship instrumentation that is disabled by default (e.g. produces too much data) so there should be a way to enable it.

[davexroth]

+1

[jcchavezs]

Question so the key in the map defines the framework?

[pavolloffay]

yes e.g. servlet

[jcchavezs]

+1

…

On Fri, 29 Jan 2021, 17:58 Pavol Loffay, ***@***.***> wrote: yes e.g. servlet — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#44 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAXOYATMHQXEZJVYXOPA35DS4LSLTANCNFSM4WZCSABQ> .

[mohit-a21]

@jcchavezs Can this be used by goagent for disabling tracing for specific packages? If this is specific to java agent and we would have to add different config for go agent, then I would prefer having this as a oneof. @pavolloffay

[jcchavezs]

@mohit-a21 that would be the idea.