Skip to content

Commit 45b88ce

Browse files
feat: add attribute definition for fallback support (#84)
* feat: add attribute definition for fallback support * chore: update framework version
1 parent c89a6b2 commit 45b88ce

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

attribute-service-api/src/main/proto/org/hypertrace/core/attribute/service/v1/attribute_metadata.proto

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ message AttributeMetadata {
8181
// can't be the same for different attribute within the same scope
8282
string key = 3;
8383
string display_name = 4;
84-
AttributeScope scope = 5 [deprecated=true]; // Use scope_string instead
84+
AttributeScope scope = 5 [deprecated = true]; // Use scope_string instead
8585
bool materialized = 6;
8686
// 1) Attributes can have units (cores / seconds) for presentation
8787
// 2) Metrics are temporarily combined, and need it for presentation
@@ -132,7 +132,7 @@ message AttributeSourceMetadataDeleteRequest {
132132
// in the future, we would need to support partial matching for auto-complete
133133
message AttributeMetadataFilter {
134134
repeated string fqn = 1;
135-
repeated AttributeScope scope = 2 [deprecated=true]; // Use scope_string instead
135+
repeated AttributeScope scope = 2 [deprecated = true]; // Use scope_string instead
136136
repeated string key = 4;
137137
repeated string scope_string = 5;
138138
}
@@ -145,13 +145,18 @@ message AttributeDefinition {
145145
Projection projection = 1;
146146
string source_path = 2;
147147
SourceField source_field = 3;
148+
AttributeDefinitions first_value_present = 4;
148149
}
149150

150151
enum SourceField {
151152
SOURCE_FIELD_UNSET = 0;
152153
SOURCE_FIELD_START_TIME = 1;
153154
SOURCE_FIELD_END_TIME = 2;
154155
}
156+
157+
message AttributeDefinitions {
158+
repeated AttributeDefinition definitions = 1;
159+
}
155160
}
156161

157162
message Projection {

attribute-service/build.gradle.kts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ tasks.integrationTest {
5656
dependencies {
5757
implementation(project(":attribute-service-impl"))
5858

59-
implementation("org.hypertrace.core.serviceframework:platform-service-framework:0.1.22")
59+
implementation("org.hypertrace.core.serviceframework:platform-service-framework:0.1.23")
6060
implementation("org.hypertrace.core.grpcutils:grpc-server-utils:0.4.0")
6161
implementation("org.hypertrace.core.documentstore:document-store:0.5.4")
6262

@@ -82,7 +82,7 @@ dependencies {
8282
integrationTestImplementation("org.junit.jupiter:junit-jupiter:5.7.1")
8383
integrationTestImplementation("com.google.guava:guava:30.1.1-jre")
8484
integrationTestImplementation(project(":attribute-service-client"))
85-
integrationTestImplementation("org.hypertrace.core.serviceframework:integrationtest-service-framework:0.1.22")
85+
integrationTestImplementation("org.hypertrace.core.serviceframework:integrationtest-service-framework:0.1.23")
8686
}
8787

8888
application {

0 commit comments

Comments
 (0)