WIP

Author: suddendust

document-store/src/test/java/org/hypertrace/core/documentstore/postgres/query/v1/parser/filter/PostgresArrayEqualityParserSelectorTest.java

@@ -6,7 +6,6 @@
 import org.hypertrace.core.documentstore.expression.impl.AggregateExpression;
 import org.hypertrace.core.documentstore.expression.impl.AliasedIdentifierExpression;
 import org.hypertrace.core.documentstore.expression.impl.ArrayIdentifierExpression;
-import org.hypertrace.core.documentstore.expression.impl.ArrayType;
 import org.hypertrace.core.documentstore.expression.impl.ConstantExpression;
 import org.hypertrace.core.documentstore.expression.impl.ConstantExpression.DocumentConstantExpression;
 import org.hypertrace.core.documentstore.expression.impl.FunctionExpression;
@@ -34,7 +33,7 @@ void testVisitJsonIdentifierExpression() {
   @Test
   void testVisitArrayIdentifierExpression() {
     PostgresArrayEqualityParserSelector selector = new PostgresArrayEqualityParserSelector();
-    ArrayIdentifierExpression expr = ArrayIdentifierExpression.of("tags", ArrayType.TEXT);
+    ArrayIdentifierExpression expr = ArrayIdentifierExpression.ofStrings("tags");
 
     Object result = selector.visit(expr);
 

document-store/src/test/java/org/hypertrace/core/documentstore/postgres/query/v1/parser/filter/PostgresTopLevelArrayEqualityFilterParserTest.java

@@ -9,7 +9,6 @@
 
 import java.util.List;
 import org.hypertrace.core.documentstore.expression.impl.ArrayIdentifierExpression;
-import org.hypertrace.core.documentstore.expression.impl.ArrayType;
 import org.hypertrace.core.documentstore.expression.impl.ConstantExpression;
 import org.hypertrace.core.documentstore.expression.impl.RelationalExpression;
 import org.hypertrace.core.documentstore.postgres.Params;
@@ -45,7 +44,7 @@ void setUp() {
 
   @Test
   void testParseNullRhs() {
-    ArrayIdentifierExpression lhs = ArrayIdentifierExpression.of("tags", ArrayType.TEXT);
+    ArrayIdentifierExpression lhs = ArrayIdentifierExpression.ofStrings("tags");
     ConstantExpression rhs = ConstantExpression.of("ignored");
     RelationalExpression expression = RelationalExpression.of(lhs, EQ, rhs);
 
@@ -68,7 +67,7 @@ void testParseNullRhs() {
 
   @Test
   void testParseScalarRhsEq() {
-    ArrayIdentifierExpression lhs = ArrayIdentifierExpression.of("tags", ArrayType.TEXT);
+    ArrayIdentifierExpression lhs = ArrayIdentifierExpression.ofStrings("tags");
     ConstantExpression rhs = ConstantExpression.of("hygiene");
     RelationalExpression expression = RelationalExpression.of(lhs, EQ, rhs);
 
@@ -83,7 +82,7 @@ void testParseScalarRhsEq() {
 
   @Test
   void testParseIterableRhsEq() {
-    ArrayIdentifierExpression lhs = ArrayIdentifierExpression.of("tags", ArrayType.TEXT);
+    ArrayIdentifierExpression lhs = ArrayIdentifierExpression.ofStrings("tags");
     ConstantExpression rhs = ConstantExpression.ofStrings(List.of("hygiene", "family-pack"));
     RelationalExpression expression = RelationalExpression.of(lhs, EQ, rhs);
 
@@ -99,7 +98,7 @@ void testParseIterableRhsEq() {
 
   @Test
   void testParseIterableRhsNeq() {
-    ArrayIdentifierExpression lhs = ArrayIdentifierExpression.of("tags", ArrayType.TEXT);
+    ArrayIdentifierExpression lhs = ArrayIdentifierExpression.ofStrings("tags");
     ConstantExpression rhs = ConstantExpression.ofStrings(List.of("a", "b"));
     RelationalExpression expression = RelationalExpression.of(lhs, NEQ, rhs);