refactor: only add aggregation in fragment if value is present (#789)

Author: anandtiwary

projects/distributed-tracing/src/public-api.ts

@@ -73,6 +73,7 @@ export {
 } from './shared/graphql/model/schema/metrics/graphql-metric-aggregation-type';
 export * from './shared/graphql/model/schema/sort/graphql-sort-argument';
 export * from './shared/graphql/model/schema/sort/graphql-sort-direction';
+export * from './shared/graphql/model/schema/sort/graphql-sort-without-direction';
 export * from './shared/graphql/model/schema/sort/graphql-sort-by-specification';
 export * from './shared/graphql/model/schema/timerange/graphql-time-range';
 export * from './shared/graphql/model/schema/specifier/specification';

projects/observability/src/shared/graphql/request/builders/specification/explore/explore-specification-builder.ts

@@ -1,8 +1,9 @@
-import { DateCoercer } from '@hypertrace/common';
+import { DateCoercer, Dictionary } from '@hypertrace/common';
 import {
   AttributeMetadataType,
   convertToGraphQlMetricAggregationType,
   GraphQlMetricAggregationType,
+  GraphQlSortWithoutDirection,
   MetricAggregationType
 } from '@hypertrace/distributed-tracing';
 import { GraphQlEnumArgument } from '@hypertrace/graphql-client';
@@ -47,10 +48,17 @@ export class ExploreSpecificationBuilder {
         children: [{ path: 'value' }, { path: 'type' }]
       }),
       extractFromServerData: serverData => serverData[queryAlias],
-      asGraphQlOrderByFragment: () => ({
-        key: key,
-        aggregation: aggregation === undefined ? undefined : this.aggregationAsEnum(aggregation)
-      })
+      asGraphQlOrderByFragment: () => {
+        const fragment: GraphQlSortWithoutDirection & Dictionary<unknown> = {
+          key: key
+        };
+
+        if (aggregation !== undefined) {
+          fragment.aggregation = this.aggregationAsEnum(aggregation);
+        }
+
+        return fragment;
+      }
     };
   }