Addressed comments

pavan-traceable · pavan-traceable · commit 77b0aac3f3fe · 2025-03-20T13:24:57.000+05:30
diff --git a/grpc-circuitbreaker-utils/src/main/java/org/hypertrace/circuitbreaker/grpcutils/CircuitBreakerConfigParser.java b/grpc-circuitbreaker-utils/src/main/java/org/hypertrace/circuitbreaker/grpcutils/CircuitBreakerConfigParser.java
@@ -28,7 +28,7 @@ public class CircuitBreakerConfigParser {
   private static final String SLIDING_WINDOW_TYPE = "slidingWindowType";
   public static final String ENABLED = "enabled";
   public static final String DEFAULT_THRESHOLDS = "defaultThresholds";
-  private static final Set<String> NON_THRESHOLD_KEYS = Set.of(ENABLED, DEFAULT_THRESHOLDS);
+  private static final Set<String> NON_THRESHOLD_KEYS = Set.of(ENABLED);
 
   public static <T> CircuitBreakerConfiguration.CircuitBreakerConfigurationBuilder<T> parseConfig(
       Config config) {
diff --git a/grpc-circuitbreaker-utils/src/main/java/org/hypertrace/circuitbreaker/grpcutils/resilience/ResilienceCircuitBreakerProvider.java b/grpc-circuitbreaker-utils/src/main/java/org/hypertrace/circuitbreaker/grpcutils/resilience/ResilienceCircuitBreakerProvider.java
@@ -29,7 +29,8 @@ public ResilienceCircuitBreakerProvider(
   }
 
   public Optional<CircuitBreaker> getCircuitBreaker(String circuitBreakerKey) {
-    if (disabledKeys.contains(circuitBreakerKey)) {
+    if (disabledKeys.contains(circuitBreakerKey)
+        || !circuitBreakerConfigMap.containsKey(circuitBreakerKey)) {
       return Optional.empty();
     }
     return Optional.of(

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,8 @@ public ResilienceCircuitBreakerProvider(`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`public Optional<CircuitBreaker> getCircuitBreaker(String circuitBreakerKey) {`
`32`		`- if (disabledKeys.contains(circuitBreakerKey)) {`
	`32`	`+ if (disabledKeys.contains(circuitBreakerKey)`
	`33`	`+ \|\| !circuitBreakerConfigMap.containsKey(circuitBreakerKey)) {`
`33`	`34`	`return Optional.empty();`
`34`	`35`	`}`
`35`	`36`	`return Optional.of(`