Skip to content

Commit 2488d67

Browse files
authored
Upgrade otel to v1.2.0 (#337)
* ⬆️ upgrade otel\ * 🚚 rename grpc dependency * 🚚 rename extension api dependency * ♻️ upgrade APIs changed in otel 1.2.0 * 🔥 remove beforeByteBuddyAgent call * ♻️ fix compile error in java-streams test class * ♻️ fix compile error in servlet-3.0 tests * ♻️ fix compile error in servlet-rw tests * ♻️ fix extension API usage in undertow-servlet * ♻️ fix extension API usage in undertow-1.4 * 🚚 fix test error as a result of manual meta-inf serivces entry * ✏️ fix package name of InstrumentationModule in AbstractInstrumenterTest javadoc * 🐛 apply bytebuddy plugin * 🚚 rename meta-inf services entry for InstrumentationModule * 🐛 add auto-instrumentation and bytebuddy plugin to webflux * ✅ update index expectations * 🐛 fix liberty path for static resources * 🐛 fix assertion on LibertyServletOnlySmokeTest
1 parent 4a92091 commit 2488d67

File tree

55 files changed

+144
-134
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

55 files changed

+144
-134
lines changed

build.gradle.kts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,9 @@ subprojects {
3232
description = "Hypertrace OpenTelemetry Javaagent"
3333

3434
extra.set("versions", mapOf(
35-
"opentelemetry" to "1.1.0",
36-
"opentelemetry_java_agent" to "1.1.0-alpha",
37-
"opentelemetry_java_agent_all" to "1.1.0",
35+
"opentelemetry" to "1.2.0",
36+
"opentelemetry_java_agent" to "1.2.0-alpha",
37+
"opentelemetry_java_agent_all" to "1.2.0",
3838
"byte_buddy" to "1.10.18",
3939
"slf4j" to "1.7.30"
4040
))

instrumentation/apache-httpasyncclient-4.1/src/main/java/io/opentelemetry/javaagent/instrumentation/hypertrace/apachehttpasyncclient/ApacheAsyncClientInstrumentationModule.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616

1717
package io.opentelemetry.javaagent.instrumentation.hypertrace.apachehttpasyncclient;
1818

19-
import static io.opentelemetry.javaagent.tooling.bytebuddy.matcher.AgentElementMatchers.implementsInterface;
20-
import static io.opentelemetry.javaagent.tooling.bytebuddy.matcher.ClassLoaderMatcher.hasClassesNamed;
19+
import static io.opentelemetry.javaagent.extension.matcher.AgentElementMatchers.implementsInterface;
20+
import static io.opentelemetry.javaagent.extension.matcher.ClassLoaderMatcher.hasClassesNamed;
2121
import static java.util.Collections.singletonMap;
2222
import static net.bytebuddy.matcher.ElementMatchers.isMethod;
2323
import static net.bytebuddy.matcher.ElementMatchers.named;
@@ -27,10 +27,10 @@
2727
import com.google.auto.service.AutoService;
2828
import io.opentelemetry.api.trace.Span;
2929
import io.opentelemetry.context.Context;
30+
import io.opentelemetry.javaagent.extension.instrumentation.InstrumentationModule;
31+
import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
3032
import io.opentelemetry.javaagent.instrumentation.apachehttpasyncclient.ApacheHttpAsyncClientInstrumentation.DelegatingRequestProducer;
3133
import io.opentelemetry.javaagent.instrumentation.hypertrace.apachehttpclient.v4_0.ApacheHttpClientUtils;
32-
import io.opentelemetry.javaagent.tooling.InstrumentationModule;
33-
import io.opentelemetry.javaagent.tooling.TypeInstrumentation;
3434
import java.io.IOException;
3535
import java.util.Collections;
3636
import java.util.List;
@@ -57,7 +57,7 @@ public ApacheAsyncClientInstrumentationModule() {
5757
}
5858

5959
@Override
60-
public int getOrder() {
60+
public int order() {
6161
return 1;
6262
}
6363

instrumentation/apache-httpclient-4.0/src/main/java/io/opentelemetry/javaagent/instrumentation/hypertrace/apachehttpclient/v4_0/ApacheClientInstrumentationModule.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
package io.opentelemetry.javaagent.instrumentation.hypertrace.apachehttpclient.v4_0;
1818

19-
import static io.opentelemetry.javaagent.tooling.bytebuddy.matcher.AgentElementMatchers.implementsInterface;
19+
import static io.opentelemetry.javaagent.extension.matcher.AgentElementMatchers.implementsInterface;
2020
import static net.bytebuddy.matcher.ElementMatchers.hasSuperType;
2121
import static net.bytebuddy.matcher.ElementMatchers.isAbstract;
2222
import static net.bytebuddy.matcher.ElementMatchers.isMethod;
@@ -25,10 +25,10 @@
2525
import static net.bytebuddy.matcher.ElementMatchers.takesArgument;
2626

2727
import com.google.auto.service.AutoService;
28+
import io.opentelemetry.javaagent.extension.instrumentation.InstrumentationModule;
29+
import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
2830
import io.opentelemetry.javaagent.instrumentation.api.CallDepthThreadLocalMap;
2931
import io.opentelemetry.javaagent.instrumentation.api.Java8BytecodeBridge;
30-
import io.opentelemetry.javaagent.tooling.InstrumentationModule;
31-
import io.opentelemetry.javaagent.tooling.TypeInstrumentation;
3232
import java.util.Arrays;
3333
import java.util.HashMap;
3434
import java.util.List;
@@ -48,7 +48,7 @@ public ApacheClientInstrumentationModule() {
4848
}
4949

5050
@Override
51-
public int getOrder() {
51+
public int order() {
5252
return 1;
5353
}
5454

instrumentation/apache-httpclient-4.0/src/main/java/io/opentelemetry/javaagent/instrumentation/hypertrace/apachehttpclient/v4_0/HttpEntityInstrumentation.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,17 +16,17 @@
1616

1717
package io.opentelemetry.javaagent.instrumentation.hypertrace.apachehttpclient.v4_0;
1818

19-
import static io.opentelemetry.javaagent.tooling.bytebuddy.matcher.AgentElementMatchers.implementsInterface;
19+
import static io.opentelemetry.javaagent.extension.matcher.AgentElementMatchers.implementsInterface;
2020
import static net.bytebuddy.matcher.ElementMatchers.is;
2121
import static net.bytebuddy.matcher.ElementMatchers.named;
2222
import static net.bytebuddy.matcher.ElementMatchers.returns;
2323
import static net.bytebuddy.matcher.ElementMatchers.takesArgument;
2424
import static net.bytebuddy.matcher.ElementMatchers.takesArguments;
2525

26+
import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
2627
import io.opentelemetry.javaagent.instrumentation.api.ContextStore;
2728
import io.opentelemetry.javaagent.instrumentation.api.InstrumentationContext;
2829
import io.opentelemetry.javaagent.instrumentation.hypertrace.apachehttpclient.v4_0.ApacheHttpClientObjectRegistry.SpanAndAttributeKey;
29-
import io.opentelemetry.javaagent.tooling.TypeInstrumentation;
3030
import java.io.InputStream;
3131
import java.io.OutputStream;
3232
import java.io.UnsupportedEncodingException;

instrumentation/build.gradle.kts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ subprojects {
1414

1515
implementation("io.opentelemetry:opentelemetry-api:${versions["opentelemetry"]}")
1616
implementation("io.opentelemetry.javaagent:opentelemetry-javaagent-tooling:${versions["opentelemetry_java_agent"]}")
17+
implementation("io.opentelemetry.javaagent:opentelemetry-javaagent-extension-api:${versions["opentelemetry_java_agent"]}")
1718
implementation("io.opentelemetry.javaagent:opentelemetry-javaagent-api:${versions["opentelemetry_java_agent"]}")
1819
implementation("io.opentelemetry.instrumentation:opentelemetry-instrumentation-api:${versions["opentelemetry_java_agent"]}")
1920
implementation(project(":javaagent-core"))

instrumentation/grpc-1.5/build.gradle.kts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,8 @@ val versions: Map<String, String> by extra
5858
val grpcVersion = "1.5.0"
5959

6060
dependencies {
61-
api("io.opentelemetry.javaagent.instrumentation:opentelemetry-javaagent-grpc-1.5:${versions["opentelemetry_java_agent"]}")
62-
api("io.opentelemetry.instrumentation:opentelemetry-grpc-1.5:${versions["opentelemetry_java_agent"]}")
61+
api("io.opentelemetry.javaagent.instrumentation:opentelemetry-javaagent-grpc-1.6:${versions["opentelemetry_java_agent"]}")
62+
api("io.opentelemetry.instrumentation:opentelemetry-grpc-1.6:${versions["opentelemetry_java_agent"]}")
6363

6464
compileOnly("io.grpc:grpc-core:${grpcVersion}")
6565
compileOnly("io.grpc:grpc-protobuf:${grpcVersion}")

instrumentation/grpc-1.5/src/main/java/io/opentelemetry/javaagent/instrumentation/hypertrace/grpc/v1_5/NettyHttp2HeadersInstrumentationModule.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,9 @@
2525
import io.grpc.Metadata;
2626
import io.netty.handler.codec.http2.Http2Headers;
2727
import io.opentelemetry.api.trace.Span;
28+
import io.opentelemetry.javaagent.extension.instrumentation.InstrumentationModule;
29+
import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
2830
import io.opentelemetry.javaagent.instrumentation.api.Java8BytecodeBridge;
29-
import io.opentelemetry.javaagent.tooling.InstrumentationModule;
30-
import io.opentelemetry.javaagent.tooling.TypeInstrumentation;
3131
import java.util.ArrayList;
3232
import java.util.Arrays;
3333
import java.util.HashMap;

instrumentation/grpc-1.5/src/main/java/io/opentelemetry/javaagent/instrumentation/hypertrace/grpc/v1_5/client/GrpcClientBodyInstrumentation.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,14 @@
1616

1717
package io.opentelemetry.javaagent.instrumentation.hypertrace.grpc.v1_5.client;
1818

19-
import static io.opentelemetry.javaagent.tooling.bytebuddy.matcher.AgentElementMatchers.extendsClass;
19+
import static io.opentelemetry.javaagent.extension.matcher.AgentElementMatchers.extendsClass;
2020
import static java.util.Collections.singletonMap;
2121
import static net.bytebuddy.matcher.ElementMatchers.declaresField;
2222
import static net.bytebuddy.matcher.ElementMatchers.isMethod;
2323
import static net.bytebuddy.matcher.ElementMatchers.named;
2424

2525
import io.grpc.ClientInterceptor;
26-
import io.opentelemetry.javaagent.tooling.TypeInstrumentation;
26+
import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
2727
import java.util.List;
2828
import java.util.Map;
2929
import net.bytebuddy.asm.Advice;

instrumentation/grpc-1.5/src/main/java/io/opentelemetry/javaagent/instrumentation/hypertrace/grpc/v1_5/client/GrpcClientBodyInstrumentationModule.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@
1717
package io.opentelemetry.javaagent.instrumentation.hypertrace.grpc.v1_5.client;
1818

1919
import com.google.auto.service.AutoService;
20+
import io.opentelemetry.javaagent.extension.instrumentation.InstrumentationModule;
21+
import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
2022
import io.opentelemetry.javaagent.instrumentation.hypertrace.grpc.v1_5.GrpcInstrumentationName;
21-
import io.opentelemetry.javaagent.tooling.InstrumentationModule;
22-
import io.opentelemetry.javaagent.tooling.TypeInstrumentation;
2323
import java.util.Collections;
2424
import java.util.List;
2525

@@ -31,7 +31,7 @@ public GrpcClientBodyInstrumentationModule() {
3131
}
3232

3333
@Override
34-
public int getOrder() {
34+
public int order() {
3535
return 1;
3636
}
3737

instrumentation/grpc-1.5/src/main/java/io/opentelemetry/javaagent/instrumentation/hypertrace/grpc/v1_5/server/GrpcServerBodyInstrumentation.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,17 +16,17 @@
1616

1717
package io.opentelemetry.javaagent.instrumentation.hypertrace.grpc.v1_5.server;
1818

19-
import static io.opentelemetry.javaagent.tooling.bytebuddy.matcher.AgentElementMatchers.safeHasSuperType;
20-
import static io.opentelemetry.javaagent.tooling.bytebuddy.matcher.ClassLoaderMatcher.hasClassesNamed;
19+
import static io.opentelemetry.javaagent.extension.matcher.AgentElementMatchers.safeHasSuperType;
20+
import static io.opentelemetry.javaagent.extension.matcher.ClassLoaderMatcher.hasClassesNamed;
2121
import static java.util.Collections.singletonMap;
2222
import static net.bytebuddy.matcher.ElementMatchers.isMethod;
2323
import static net.bytebuddy.matcher.ElementMatchers.isPublic;
2424
import static net.bytebuddy.matcher.ElementMatchers.named;
2525
import static net.bytebuddy.matcher.ElementMatchers.takesArguments;
2626

2727
import io.grpc.ServerBuilder;
28+
import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
2829
import io.opentelemetry.javaagent.instrumentation.api.CallDepthThreadLocalMap;
29-
import io.opentelemetry.javaagent.tooling.TypeInstrumentation;
3030
import java.util.Map;
3131
import net.bytebuddy.asm.Advice;
3232
import net.bytebuddy.description.method.MethodDescription;

0 commit comments

Comments
 (0)