Skip to content

Commit 312d34e

Browse files
authored
Bump to OTEL 0.10.0 (#120)
* Bump to OTEL 0.10.0 Signed-off-by: Pavol Loffay <[email protected]> * fully working Signed-off-by: Pavol Loffay <[email protected]> * Cleanup Signed-off-by: Pavol Loffay <[email protected]> * Fix Signed-off-by: Pavol Loffay <[email protected]>
1 parent f301e05 commit 312d34e

File tree

45 files changed

+136
-186
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

45 files changed

+136
-186
lines changed

buildSrc/src/main/groovy/MuzzlePlugin.groovy

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ class MuzzlePlugin implements Plugin<Project> {
8282
println "Muzzle executing for $project"
8383
}
8484
}
85-
def printReferences = project.task('printReferences') {
85+
def printReferences = project.task('printMuzzleReferences') {
8686
group = 'Muzzle'
8787
description = "Print references created by instrumentation muzzle"
8888
doLast {
@@ -101,7 +101,7 @@ class MuzzlePlugin implements Plugin<Project> {
101101
}
102102
}
103103
project.tasks.muzzle.dependsOn(project.tasks.compileMuzzle)
104-
project.tasks.printReferences.dependsOn(project.tasks.compileMuzzle)
104+
project.tasks.printMuzzleReferences.dependsOn(project.tasks.compileMuzzle)
105105

106106
def hasRelevantTask = project.gradle.startParameter.taskNames.any { taskName ->
107107
// removing leading ':' if present

buildSrc/src/main/java/io/opentelemetry/instrumentation/gradle/AutoInstrumentationPlugin.java

Lines changed: 2 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -48,17 +48,8 @@ public class AutoInstrumentationPlugin implements Plugin<Project> {
4848
static {
4949
String[] testBS = {
5050
"io.opentelemetry.instrumentation.api",
51-
"io.opentelemetry.OpenTelemetry", // OpenTelemetry API
52-
"io.opentelemetry.common", // OpenTelemetry API
53-
"io.opentelemetry.baggage", // OpenTelemetry API
54-
"io.opentelemetry.context", // OpenTelemetry API (context prop)
55-
"io.opentelemetry.internal", // OpenTelemetry API
56-
"io.opentelemetry.metrics", // OpenTelemetry API
57-
"io.opentelemetry.trace", // OpenTelemetry API
58-
"io.grpc.Context", // OpenTelemetry API dependency
59-
"io.grpc.Deadline", // OpenTelemetry API dependency
60-
"io.grpc.PersistentHashArrayMappedTrie", // OpenTelemetry API dependency
61-
"io.grpc.ThreadLocalContextStorage", // OpenTelemetry API dependency
51+
"io.opentelemetry.api", // OpenTelemetry API
52+
"io.opentelemetry.context", // OpenTelemetry API
6253
"org.slf4j",
6354
"ch.qos.logback",
6455
// Tomcat's servlet classes must be on boostrap
@@ -77,8 +68,6 @@ public class AutoInstrumentationPlugin implements Plugin<Project> {
7768
}
7869
}
7970

80-
private static final String[] NOT_BOOTSTRAP_PREFIXES = {"io/grpc/Contexts"};
81-
8271
@Override
8372
public void apply(Project project) {
8473
project.getPlugins().apply(JavaLibraryPlugin.class);
@@ -163,11 +152,6 @@ public Iterable<String> asArguments() {
163152
}
164153

165154
private static boolean isBootstrapClass(String filePath) {
166-
for (String notBootstrapName : NOT_BOOTSTRAP_PREFIXES) {
167-
if (filePath.startsWith(notBootstrapName)) {
168-
return false;
169-
}
170-
}
171155
for (String testBootstrapPrefix : TEST_BOOTSTRAP_PREFIXES) {
172156
if (filePath.startsWith(testBootstrapPrefix)) {
173157
return true;

filter-api/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ plugins {
33
}
44

55
dependencies {
6-
api("io.opentelemetry:opentelemetry-api:0.9.1")
6+
api("io.opentelemetry:opentelemetry-api:0.10.0")
77
api(project(":javaagent-core"))
88
implementation("com.google.auto.service:auto-service:1.0-rc7")
99
annotationProcessor("com.google.auto.service:auto-service:1.0-rc7")

filter-api/src/main/java/org/hypertrace/agent/filter/MultiFilter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
package org.hypertrace.agent.filter;
1818

19-
import io.opentelemetry.trace.Span;
19+
import io.opentelemetry.api.trace.Span;
2020
import java.util.List;
2121
import java.util.Map;
2222
import org.hypertrace.agent.filter.api.ExecutionBlocked;

filter-api/src/main/java/org/hypertrace/agent/filter/api/Filter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
package org.hypertrace.agent.filter.api;
1818

19-
import io.opentelemetry.trace.Span;
19+
import io.opentelemetry.api.trace.Span;
2020
import java.util.Map;
2121
import org.hypertrace.agent.filter.FilterRegistry;
2222

filter-api/src/main/java/org/hypertrace/agent/filter/mock/MockFilter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
package org.hypertrace.agent.filter.mock;
1818

19-
import io.opentelemetry.trace.Span;
19+
import io.opentelemetry.api.trace.Span;
2020
import java.util.Map;
2121
import org.hypertrace.agent.filter.api.ExecutionBlocked;
2222
import org.hypertrace.agent.filter.api.ExecutionNotBlocked;

filter-custom-opa/src/main/java/org/hypertrace/agent/filter/opa/custom/CustomOpaLib.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
package org.hypertrace.agent.filter.opa.custom;
1818

1919
import com.google.auto.service.AutoService;
20+
import io.opentelemetry.api.trace.Span;
2021
import java.util.HashSet;
2122
import java.util.Map;
2223
import java.util.Set;
@@ -86,8 +87,7 @@ public void run() {
8687
// }
8788

8889
@Override
89-
public FilterResult evaluateRequestHeaders(
90-
io.opentelemetry.trace.Span span, Map<String, String> headers) {
90+
public FilterResult evaluateRequestHeaders(Span span, Map<String, String> headers) {
9191
// currently as per policy.rego, allowed list has precedence over denylist
9292
boolean allow =
9393
policyEvaluators.stream()
@@ -99,7 +99,7 @@ public FilterResult evaluateRequestHeaders(
9999
}
100100

101101
@Override
102-
public FilterResult evaluateRequestBody(io.opentelemetry.trace.Span span, String body) {
102+
public FilterResult evaluateRequestBody(Span span, String body) {
103103
return ExecutionNotBlocked.INSTANCE;
104104
}
105105
}

instrumentation/build.gradle.kts

Lines changed: 6 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@ subprojects {
1010
annotationProcessor("com.google.auto.service:auto-service:1.0-rc7")
1111
implementation("net.bytebuddy:byte-buddy:1.10.10")
1212

13-
implementation("io.opentelemetry:opentelemetry-api:0.9.1")
14-
implementation("io.opentelemetry.javaagent:opentelemetry-javaagent-tooling:0.9.0")
15-
implementation("io.opentelemetry.instrumentation:opentelemetry-instrumentation-api:0.9.0")
13+
implementation("io.opentelemetry:opentelemetry-api:0.10.0")
14+
implementation("io.opentelemetry.javaagent:opentelemetry-javaagent-tooling:0.10.1")
15+
implementation("io.opentelemetry.instrumentation:opentelemetry-instrumentation-api:0.10.1")
1616
implementation(project(":javaagent-core"))
1717
implementation(project(":filter-api"))
1818
}
@@ -55,32 +55,21 @@ tasks {
5555

5656
exclude("**/module-info.class")
5757

58-
// Prevents conflict with other SLF4J instances. Important for premain.
59-
relocate("org.slf4j", "io.opentelemetry.javaagent.slf4j")
6058
// rewrite dependencies calling Logger.getLogger
6159
relocate("java.util.logging.Logger", "io.opentelemetry.javaagent.bootstrap.PatchLogger")
6260

6361
// prevents conflict with library instrumentation
6462
relocate("io.opentelemetry.instrumentation.api", "io.opentelemetry.javaagent.shaded.instrumentation.api")
63+
relocate("org.slf4j", "io.opentelemetry.javaagent.slf4j")
6564

6665
// relocate OpenTelemetry API
67-
relocate("io.opentelemetry.OpenTelemetry", "io.opentelemetry.javaagent.shaded.io.opentelemetry.OpenTelemetry")
68-
relocate("io.opentelemetry.common", "io.opentelemetry.javaagent.shaded.io.opentelemetry.common")
69-
relocate("io.opentelemetry.baggage", "io.opentelemetry.javaagent.shaded.io.opentelemetry.baggage")
66+
relocate("io.opentelemetry.api", "io.opentelemetry.javaagent.shaded.io.opentelemetry.api")
7067
relocate("io.opentelemetry.context", "io.opentelemetry.javaagent.shaded.io.opentelemetry.context")
71-
relocate("io.opentelemetry.internal", "io.opentelemetry.javaagent.shaded.io.opentelemetry.internal")
72-
relocate("io.opentelemetry.metrics", "io.opentelemetry.javaagent.shaded.io.opentelemetry.metrics")
73-
relocate("io.opentelemetry.trace", "io.opentelemetry.javaagent.shaded.io.opentelemetry.trace")
74-
75-
relocate("org.slf4j", "io.opentelemetry.javaagent.slf4j")
7668

7769
//opentelemetry rewrite library instrumentation dependencies
7870
relocate("io.opentelemetry.instrumentation", "io.opentelemetry.javaagent.shaded.instrumentation") {
79-
exclude("io.opentelemetry.instrumentation.auto.**")
71+
exclude("io.opentelemetry.javaagent.instrumentation.**")
8072
exclude("io.opentelemetry.instrumentation.hypertrace.**")
8173
}
82-
83-
// relocate OpenTelemetry API dependency
84-
relocate("io.grpc", "io.opentelemetry.javaagent.shaded.io.grpc")
8574
}
8675
}

instrumentation/grpc-1.5/build.gradle.kts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,8 @@ protobuf {
5656
}
5757

5858
dependencies {
59-
api("io.opentelemetry.javaagent.instrumentation:opentelemetry-javaagent-grpc-1.5:0.9.0")
60-
api("io.opentelemetry.instrumentation:opentelemetry-grpc-1.5:0.9.0")
59+
api("io.opentelemetry.javaagent.instrumentation:opentelemetry-javaagent-grpc-1.5:0.10.1")
60+
api("io.opentelemetry.instrumentation:opentelemetry-grpc-1.5:0.10.1")
6161

6262
compileOnly("io.grpc:grpc-core:1.5.0")
6363
compileOnly("io.grpc:grpc-protobuf:1.5.0")

instrumentation/grpc-1.5/src/main/java/io/opentelemetry/instrumentation/hypertrace/grpc/v1_5/GrpcSpanDecorator.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@
2121
import com.google.protobuf.util.JsonFormat;
2222
import io.grpc.Metadata;
2323
import io.grpc.Metadata.Key;
24-
import io.opentelemetry.common.AttributeKey;
25-
import io.opentelemetry.trace.Span;
24+
import io.opentelemetry.api.common.AttributeKey;
25+
import io.opentelemetry.api.trace.Span;
2626
import java.util.LinkedHashMap;
2727
import java.util.Map;
2828
import java.util.function.Function;

0 commit comments

Comments
 (0)