Skip to content

Commit 777d4b1

Browse files
authored
order installers, filter components should be after configs (#384)
1 parent c66faa5 commit 777d4b1

File tree

4 files changed

+24
-0
lines changed

4 files changed

+24
-0
lines changed

otel-extensions/src/main/java/org/hypertrace/agent/otel/extensions/FilterComponentInstaller.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,4 +43,10 @@ public void beforeAgent(AutoConfiguredOpenTelemetrySdk autoConfiguredOpenTelemet
4343
// resolves filter via service loader resolution
4444
FilterRegistry.initialize(providerConfig, jarPaths, getClass().getClassLoader());
4545
}
46+
47+
@Override
48+
public int order() {
49+
// Configs should be loaded before FilterComponents because filters use configs
50+
return 1;
51+
}
4652
}

otel-extensions/src/main/java/org/hypertrace/agent/otel/extensions/config/DataCaptureConfigInstaller.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,4 +29,10 @@ public class DataCaptureConfigInstaller implements BeforeAgentListener {
2929
public void beforeAgent(AutoConfiguredOpenTelemetrySdk autoConfiguredOpenTelemetrySdk) {
3030
ConfigProvider.get(getClass().getClassLoader());
3131
}
32+
33+
@Override
34+
public int order() {
35+
// Configs should be loaded before FilterComponents because filters use configs
36+
return 0;
37+
}
3238
}

otel-extensions/src/main/java/org/hypertrace/agent/otel/extensions/config/InstrumentationConfigInstaller.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,4 +28,10 @@ public class InstrumentationConfigInstaller implements BeforeAgentListener {
2828
public void beforeAgent(AutoConfiguredOpenTelemetrySdk autoConfiguredOpenTelemetrySdk) {
2929
ConfigProvider.get(getClass().getClassLoader());
3030
}
31+
32+
@Override
33+
public int order() {
34+
// Configs should be loaded before FilterComponents because filters use configs
35+
return 0;
36+
}
3137
}

otel-extensions/src/main/java/org/hypertrace/agent/otel/extensions/config/ReportingConfigInstaller.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,4 +28,10 @@ public class ReportingConfigInstaller implements BeforeAgentListener {
2828
public void beforeAgent(AutoConfiguredOpenTelemetrySdk autoConfiguredOpenTelemetrySdk) {
2929
ConfigProvider.get(getClass().getClassLoader());
3030
}
31+
32+
@Override
33+
public int order() {
34+
// Configs should be loaded before FilterComponents because filters use configs
35+
return 0;
36+
}
3137
}

0 commit comments

Comments
 (0)