Skip to content

Commit d96029f

Browse files
authored
Refactor how common test dependencies are defined (#86)
Signed-off-by: Pavol Loffay <[email protected]>
1 parent 29d165a commit d96029f

File tree

4 files changed

+14
-9
lines changed

4 files changed

+14
-9
lines changed

build.gradle.kts

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,11 @@ allprojects {
1313
}
1414
}
1515

16+
val testDependencies by configurations.creating {
17+
extendsFrom(configurations.testImplementation.get())
18+
extendsFrom(configurations.testRuntimeOnly.get())
19+
}
20+
1621
subprojects {
1722
group = "org.hypertrace.agent"
1823
description = "Hypertrace OpenTelemetry Javaagent"
@@ -39,9 +44,9 @@ subprojects {
3944
}
4045

4146
dependencies {
42-
testImplementation("org.mockito:mockito-core:3.3.3")
43-
testImplementation("org.junit.jupiter:junit-jupiter-api:5.6.2")
44-
testRuntimeOnly("org.junit.jupiter:junit-jupiter-engine:5.6.2")
47+
testImplementation("org.junit.jupiter:junit-jupiter-api:5.7.0")
48+
testRuntimeOnly("org.junit.jupiter:junit-jupiter-engine:5.7.0")
49+
testImplementation("org.junit-pioneer:junit-pioneer:1.0.0")
4550
}
4651

4752
tasks {

instrumentation/grpc-1.5/src/test/java/io/opentelemetry/instrumentation/hypertrace/grpc/v1_5/GrpcBodyTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@
4848
import org.junit.jupiter.api.Assertions;
4949
import org.junit.jupiter.api.BeforeAll;
5050
import org.junit.jupiter.api.Test;
51+
import org.junitpioneer.jupiter.ClearSystemProperty;
5152

5253
public class GrpcBodyTest extends AbstractInstrumenterTest {
5354

@@ -108,7 +109,6 @@ public static void close() {
108109

109110
@AfterEach
110111
public void afterEach() {
111-
System.clearProperty(EnvironmentConfig.CAPTURE_HTTP_BODY_PREFIX + "request");
112112
HypertraceConfig.reset();
113113
}
114114

@@ -168,6 +168,7 @@ public void serverRequestBlocking() throws TimeoutException, InterruptedExceptio
168168
}
169169

170170
@Test
171+
@ClearSystemProperty(key = EnvironmentConfig.CAPTURE_HTTP_HEADERS_PREFIX + "request")
171172
public void disabledInstrumentation_dynamicConfig()
172173
throws TimeoutException, InterruptedException {
173174
System.setProperty(EnvironmentConfig.CAPTURE_HTTP_BODY_PREFIX + "request", "false");

javaagent-core/build.gradle.kts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,4 @@ dependencies {
2828
api("com.google.protobuf:protobuf-java-util:3.13.0")
2929
// convert yaml to json, since java protobuf impl supports only json
3030
implementation("com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:2.11.3")
31-
32-
testImplementation("org.junit-pioneer:junit-pioneer:1.0.0")
3331
}

testing-common/build.gradle.kts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,11 @@ plugins {
33
id("net.bytebuddy.byte-buddy-gradle-plugin") version "1.10.10"
44
}
55

6-
dependencies {
7-
implementation("org.junit.jupiter:junit-jupiter-api:5.6.2")
8-
implementation("org.junit.jupiter:junit-jupiter-engine:5.6.2")
6+
configurations {
7+
implementation.get().extendsFrom(project(":").configurations["testDependencies"])
8+
}
99

10+
dependencies {
1011
api("io.opentelemetry:opentelemetry-sdk:0.9.1")
1112
implementation("io.opentelemetry.javaagent:opentelemetry-javaagent-api:0.9.0")
1213
implementation("io.opentelemetry.javaagent:opentelemetry-javaagent-tooling:0.9.0")

0 commit comments

Comments
 (0)