Handle all exceptions if call to "/quitquitquit" fails. Otherwise the failure causes pod to just hang. (#34)

saxenakshitiz · web-flow · commit 453660be771c · 2021-08-08T22:53:58.000+05:30
diff --git a/platform-service-framework/src/main/java/org/hypertrace/core/serviceframework/PlatformServiceLauncher.java b/platform-service-framework/src/main/java/org/hypertrace/core/serviceframework/PlatformServiceLauncher.java
@@ -1,6 +1,5 @@
 package org.hypertrace.core.serviceframework;
 
-import java.io.IOException;
 import org.apache.http.client.HttpClient;
 import org.apache.http.client.methods.HttpPost;
 import org.apache.http.impl.client.HttpClients;
@@ -63,7 +62,7 @@ private static void finalizeService() {
     try {
       httpclient.execute(httppost);
       LOGGER.info("Request to pilot succeeded");
-    } catch (IOException e) {
+    } catch (Exception e) {
       LOGGER.error("Error while calling quitquitquit", e);
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,5 @@`
`1`	`1`	`package org.hypertrace.core.serviceframework;`
`2`	`2`
`3`		`-import java.io.IOException;`
`4`	`3`	`import org.apache.http.client.HttpClient;`
`5`	`4`	`import org.apache.http.client.methods.HttpPost;`
`6`	`5`	`import org.apache.http.impl.client.HttpClients;`
`@@ -63,7 +62,7 @@ private static void finalizeService() {`
`63`	`62`	`try {`
`64`	`63`	`httpclient.execute(httppost);`
`65`	`64`	`LOGGER.info("Request to pilot succeeded");`
`66`		`- } catch (IOException e) {`
	`65`	`+ } catch (Exception e) {`
`67`	`66`	`LOGGER.error("Error while calling quitquitquit", e);`
`68`	`67`	`}`
`69`	`68`	`}`