Skip to content

Commit 6b7860b

Browse files
Fix issue where guage metrics arent reported at times (#29)
Reference: https://stackoverflow.com/questions/50821924/micrometer-prometheus-gauge-displays-nan
1 parent 65dcd0e commit 6b7860b

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

platform-metrics/src/main/java/org/hypertrace/core/serviceframework/metrics/PlatformMetricsRegistry.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
import io.github.mweirauch.micrometer.jvm.extras.ProcessThreadMetrics;
1414
import io.micrometer.core.instrument.Clock;
1515
import io.micrometer.core.instrument.Counter;
16+
import io.micrometer.core.instrument.Gauge;
1617
import io.micrometer.core.instrument.ImmutableTag;
1718
import io.micrometer.core.instrument.MeterRegistry;
1819
import io.micrometer.core.instrument.Tag;
@@ -334,7 +335,8 @@ public static Timer registerTimer(String name, Map<String, String> tags, boolean
334335
* See https://micrometer.io/docs/concepts#_gauges for more details on the Gauges.
335336
*/
336337
public static <T extends Number> T registerGauge(String name, Map<String, String> tags, T number) {
337-
return METER_REGISTRY.gauge(name, addDefaultTags(tags), number);
338+
Gauge.builder(name, number, Number::doubleValue).tags(addDefaultTags(tags)).strongReference(true).register(METER_REGISTRY);
339+
return number;
338340
}
339341

340342
/**

0 commit comments

Comments
 (0)