fix: make LimitedMaxHeap compatible with PHP 8.4

Author: albertcht

composer.json

@@ -172,7 +172,7 @@
     },
     "require-dev": {
         "ably/ably-php": "^1.0",
-        "fakerphp/faker": "^2.0",
+        "fakerphp/faker": "^1.24.1",
         "filp/whoops": "^2.15",
         "friendsofphp/php-cs-fixer": "^3.57.2",
         "hyperf/devtool": "~3.1.0",
@@ -184,7 +184,7 @@
         "league/flysystem-google-cloud-storage": "^3.0",
         "league/flysystem-path-prefixing": "^3.3",
         "league/flysystem-read-only": "^3.3",
-        "mockery/mockery": "^1.5.1",
+        "mockery/mockery": "1.6.x-dev",
         "nunomaduro/collision": "^8.5",
         "pda/pheanstalk": "v5.0.9",
         "phpstan/phpstan": "^1.11.5",

src/cache/src/LimitedMaxHeap.php

@@ -12,18 +12,16 @@ public function __construct(protected int $limit)
     {
     }
 
-    public function insert(mixed $value): bool
+    public function insert(mixed $value): true
     {
         if ($this->count() < $this->limit) {
             return parent::insert($value);
         }
 
         if ($this->compare($value, $this->top()) < 0) {
             $this->extract();
-
-            return parent::insert($value);
         }
 
-        return false;
+        return parent::insert($value);
     }
 }