Commit 92568df
committed
Fix operator precedence bugs and PSR-7 getHeader usage
FilesystemManager: Fix operator precedence in read-only check
- `?? false === true` was parsed as `?? (false === true)`
- Now correctly checks `($config['read-only'] ?? false) === true`
StartSession: Fix operator precedence in AJAX detection
- `! header(...) === 'X'` was parsed as `(! header(...)) === 'X'`
- Boolean === string is always false, so storeCurrentUrl never worked
- Now correctly checks `header(...) !== 'XMLHttpRequest'`
TestResponseAssert: Fix PSR-7 getHeader returns array not string
- `getHeader()` returns string[], not string
- Array === string is always false, so JSON error injection never worked
- Now correctly uses `getHeader(...)[0] ?? ''` with str_contains1 parent df1da4c commit 92568df
File tree
3 files changed
+3
-3
lines changed- src
- filesystem/src
- foundation/src/Testing
- session/src/Middleware
3 files changed
+3
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
379 | 379 | | |
380 | 380 | | |
381 | 381 | | |
382 | | - | |
| 382 | + | |
383 | 383 | | |
384 | 384 | | |
385 | 385 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
64 | | - | |
| 64 | + | |
65 | 65 | | |
66 | 66 | | |
67 | 67 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
158 | 158 | | |
159 | 159 | | |
160 | 160 | | |
161 | | - | |
| 161 | + | |
162 | 162 | | |
163 | 163 | | |
164 | 164 | | |
| |||
0 commit comments