Skip to content

Commit df2aabd

Browse files
committed
fix: fix dependency of pool manager in ObjectRecycler
1 parent 62a4c69 commit df2aabd

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

src/object-pool/src/ObjectRecycler.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66

77
use DateTime;
88
use Hyperf\Coordinator\Timer;
9+
use Hypervel\ObjectPool\Contracts\Factory as PoolFactory;
910
use Hypervel\ObjectPool\Contracts\Recycler;
1011
use RuntimeException;
1112

@@ -24,11 +25,11 @@ class ObjectRecycler implements Recycler
2425
/**
2526
* Creates a new object recycler with the given configuration.
2627
*
27-
* @param PoolManager $manager the pool manager instance to manage object pools
28+
* @param PoolFactory $manager the pool manager instance to manage object pools
2829
* @param float $interval the interval between automatic recycle checks in seconds
2930
*/
3031
public function __construct(
31-
protected PoolManager $manager,
32+
protected PoolFactory $manager,
3233
protected float $interval = 10.0,
3334
) {
3435
}

tests/ObjectPool/ObjectRecyclerTest.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@
66

77
use Carbon\Carbon;
88
use Hyperf\Coordinator\Timer;
9+
use Hypervel\ObjectPool\Contracts\Factory as PoolFactory;
910
use Hypervel\ObjectPool\Contracts\ObjectPool;
1011
use Hypervel\ObjectPool\ObjectRecycler;
11-
use Hypervel\ObjectPool\PoolManager;
1212
use Hypervel\Tests\TestCase;
1313
use Mockery;
1414

@@ -27,7 +27,7 @@ public function testStart()
2727
->andReturn($timerId = 99);
2828

2929
$recycler = new ObjectRecycler(
30-
Mockery::mock(PoolManager::class),
30+
Mockery::mock(PoolFactory::class),
3131
$interval
3232
);
3333
$recycler->setTimer($timer);
@@ -45,7 +45,7 @@ public function testStop()
4545
->andReturn($timerId = 99);
4646

4747
$recycler = new ObjectRecycler(
48-
Mockery::mock(PoolManager::class),
48+
Mockery::mock(PoolFactory::class),
4949
$interval
5050
);
5151
$recycler->setTimer($timer);
@@ -69,8 +69,8 @@ public function testGetLastRecycledAt()
6969
->once()
7070
->andReturn($lastRecycledAt = Carbon::now());
7171

72-
$manager = Mockery::mock(PoolManager::class);
73-
$manager->shouldReceive('getPool')
72+
$manager = Mockery::mock(PoolFactory::class);
73+
$manager->shouldReceive('get')
7474
->once()
7575
->with('foo')
7676
->andReturn($pool);

0 commit comments

Comments
 (0)