Remove shouldShowInTab unused function

Author: Alejandro Celaya

src/sidebar/helpers/tabs.ts

@@ -15,15 +15,3 @@ export function tabForAnnotation(ann: Annotation): TabName {
     return 'annotation';
   }
 }
-
-/**
- * Return true if an annotation should be displayed in a given tab.
- */
-export function shouldShowInTab(ann: Annotation, tab: TabName): boolean {
-  if (metadata.isWaitingToAnchor(ann)) {
-    // Until this annotation anchors or fails to anchor, we do not know which
-    // tab it should be displayed in.
-    return false;
-  }
-  return tabForAnnotation(ann) === tab;
-}

src/sidebar/helpers/test/tabs-test.js

@@ -24,55 +24,4 @@ describe('sidebar/helpers/tabs', () => {
       });
     });
   });
-
-  describe('shouldShowInTab', () => {
-    [
-      {
-        // Anchoring in progress.
-        anchorTimeout: false,
-        orphan: undefined,
-        expectedTab: null,
-      },
-      {
-        // Anchoring succeeded.
-        anchorTimeout: false,
-        orphan: false,
-        expectedTab: 'annotation',
-      },
-      {
-        // Anchoring failed.
-        anchorTimeout: false,
-        orphan: true,
-        expectedTab: 'orphan',
-      },
-      {
-        // Anchoring timed out.
-        anchorTimeout: true,
-        orphan: undefined,
-        expectedTab: 'annotation',
-      },
-      {
-        // Anchoring initially timed out but eventually
-        // failed.
-        anchorTimeout: true,
-        orphan: true,
-        expectedTab: 'orphan',
-      },
-    ].forEach(testCase => {
-      it('returns true if the annotation should be shown', () => {
-        const ann = fixtures.defaultAnnotation();
-        ann.$anchorTimeout = testCase.anchorTimeout;
-        ann.$orphan = testCase.orphan;
-
-        assert.equal(
-          tabs.shouldShowInTab(ann, 'annotation'),
-          testCase.expectedTab === 'annotation',
-        );
-        assert.equal(
-          tabs.shouldShowInTab(ann, 'orphan'),
-          testCase.expectedTab === 'orphan',
-        );
-      });
-    });
-  });
 });