Remove unused function that was missing types

Author: robertknight

src/sidebar/helpers/session.js

@@ -5,17 +5,6 @@ import { serviceConfig } from '../config/service-config';
  * @typedef {import('../../types/api').Profile} Profile
  */
 
-/**
- * Returns true if the sidebar tutorial has to be shown to a user for a given session.
- * @deprecated To be removed once preact help/tutorial panel is in place
- */
-export function shouldShowSidebarTutorial(sessionState) {
-  if (sessionState.preferences.show_sidebar_tutorial) {
-    return true;
-  }
-  return false;
-}
-
 /**
  * The following things must all be true for the tutorial component to auto-display
  * on app launch:

src/sidebar/helpers/test/session-test.js

@@ -1,29 +1,7 @@
 import * as sessionUtil from '../session';
 
 describe('sidebar/helpers/session', () => {
-  describe('#shouldShowSidebarTutorial', () => {
-    it('shows sidebar tutorial if the settings object has the show_sidebar_tutorial key set', () => {
-      const sessionState = {
-        preferences: {
-          show_sidebar_tutorial: true,
-        },
-      };
-
-      assert.isTrue(sessionUtil.shouldShowSidebarTutorial(sessionState));
-    });
-
-    it('hides sidebar tutorial if the settings object does not have the show_sidebar_tutorial key set', () => {
-      const sessionState = {
-        preferences: {
-          show_sidebar_tutorial: false,
-        },
-      };
-
-      assert.isFalse(sessionUtil.shouldShowSidebarTutorial(sessionState));
-    });
-  });
-
-  describe('#shouldAutoDisplayTutorial', () => {
+  describe('shouldAutoDisplayTutorial', () => {
     [
       {
         // The only "true" state