Skip to content

Commit d5ace95

Browse files
committed
Reset callback before checking for absence of call
This pattern makes it clearer that we are testing for a callback not being invoked after a sequence of events.
1 parent f7ab8ac commit d5ace95

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

src/annotator/test/frame-observer-test.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -235,12 +235,13 @@ describe('annotator/frame-observer', () => {
235235

236236
const unsubscribe = onDocumentReady(frame, callback);
237237
await waitForCall(callback);
238+
callback.resetHistory();
238239

239240
unsubscribe();
240241
frame.src = sameOriginURL + '?v2';
241242
await waitForEvent(frame, 'load');
242243

243-
assert.calledOnce(callback);
244+
assert.notCalled(callback);
244245
});
245246

246247
it('does not start polling if "unload" event is received after subscription is canceled', async () => {
@@ -253,6 +254,7 @@ describe('annotator/frame-observer', () => {
253254
const unsubscribe = onDocumentReady(frame, callback);
254255
clock.tick();
255256
assert.calledOnce(callback);
257+
callback.resetHistory();
256258

257259
const contentWindow = frame.contentWindow;
258260
unsubscribe();
@@ -262,7 +264,7 @@ describe('annotator/frame-observer', () => {
262264
await waitForEvent(frame, 'load');
263265
clock.tick(50); // Wait for any active polling to trigger
264266

265-
assert.calledOnce(callback);
267+
assert.notCalled(callback);
266268
} finally {
267269
clock.restore();
268270
}

0 commit comments

Comments
 (0)