Skip to content

Commit 6f5a764

Browse files
authored
Merge pull request #167 from cdmh/missing_move_assignment
Missing move assignment
2 parents 2d82fe6 + 9dcd90c commit 6f5a764

File tree

3 files changed

+9
-0
lines changed

3 files changed

+9
-0
lines changed

.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,3 +48,5 @@ cmake-build-debug/
4848

4949
# macOS compilation dirs
5050
*.dSYM
51+
52+
.vscode/*

src/SQLParserResult.cpp

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,18 @@ namespace hsql {
1616

1717
// Move constructor.
1818
SQLParserResult::SQLParserResult(SQLParserResult&& moved) {
19+
*this = std::forward<SQLParserResult>(moved);
20+
}
21+
22+
SQLParserResult &SQLParserResult::operator=(SQLParserResult&& moved)
23+
{
1924
isValid_ = moved.isValid_;
2025
errorMsg_ = moved.errorMsg_;
2126
statements_ = std::move(moved.statements_);
2227

2328
moved.errorMsg_ = nullptr;
2429
moved.reset();
30+
return *this;
2531
}
2632

2733
SQLParserResult::~SQLParserResult() {

src/SQLParserResult.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ namespace hsql {
1717

1818
// Move constructor.
1919
SQLParserResult(SQLParserResult&& moved);
20+
SQLParserResult &operator=(SQLParserResult&& moved);
2021

2122
// Deletes all statements in the result.
2223
virtual ~SQLParserResult();

0 commit comments

Comments
 (0)