ENH: Address issues raised by refurb. [skip ci]

Author: Taher Chegini

conftest.py

@@ -22,15 +22,14 @@ def _add_standard_imports(doctest_namespace):
 @pytest.fixture()
 def wms_resp():
     """Return a WMS response."""
-    wms = WMS(
+    return WMS(
         ServiceURL().wms.mrlc,
         layers="nlcd_tcc_conus_2011_v2021-4",
         outformat="image/geotiff",
         crs=DEF_CRS,
         validation=False,
         ssl=False,
-    )
-    return wms.getmap_bybox(
+    ).getmap_bybox(
         GEO_NAT.bounds,
         1e3,
         box_crs=DEF_CRS,
@@ -40,15 +39,14 @@ def wms_resp():
 @pytest.fixture()
 def gtiff_list():
     """Return a WMS response."""
-    wms = WMS(
+    return WMS(
         ServiceURL().wms.mrlc,
         layers="NLCD_2019_Land_Cover_Science_Product_L48",
         outformat="image/geotiff",
         crs=DEF_CRS,
         validation=False,
         ssl=False,
-    )
-    return wms.getmap_bybox(
+    ).getmap_bybox(
         GEO_NAT.bounds,
         1e3,
         box_crs=DEF_CRS,

pygeoutils/exceptions.py

@@ -14,7 +14,7 @@ class MissingColumnError(Exception):
     """
 
     def __init__(self, missing: list[str]) -> None:
-        self.message = "The following columns are missing:\n" + f"{', '.join(missing)}"
+        self.message = f"The following columns are missing:\n{', '.join(missing)}"
         super().__init__(self.message)
 
     def __str__(self) -> str:

pygeoutils/geotools.py

@@ -786,9 +786,9 @@ def break_lines(lines: GDFTYPE, points: gpd.GeoDataFrame, tol: float = 0.0) -> G
         crs=crs_proj,
         index=idx,
     )
-    out = lines.loc[idx].drop(columns="geometry")
-    out = gpd.GeoDataFrame(out, geometry=broken_lines, crs=crs_proj)
-    return out.to_crs(lines.crs)
+    return gpd.GeoDataFrame(
+        lines.loc[idx].drop(columns="geometry"), geometry=broken_lines, crs=crs_proj
+    ).to_crs(lines.crs)
 
 
 def geometry_list(geometry: GEOM) -> list[Polygon] | list[Point] | list[LineString]: