Merge pull request The-OpenROAD-Project#9627 from hzeller/feature-20260304-remove-unused-param

Remove unused paramters in constructors.

Author: maliberty

src/cts/src/TechChar.cpp

@@ -47,7 +47,6 @@ using utl::CTS;
 TechChar::TechChar(CtsOptions* options,
                    odb::dbDatabase* db,
                    sta::dbSta* sta,
-                   rsz::Resizer* /*resizer not-used*/,
                    est::EstimateParasitics* estimate_parasitics,
                    sta::dbNetwork* db_network,
                    utl::Logger* logger)
@@ -1298,7 +1297,7 @@ void TechChar::updateBufferTopologiesOld(TechChar::SolutionData& solution)
       odb::dbInst* inst = solution.instVector[index];
       inst->swapMaster(newBufMaster);
       // clang-format off
-      --masterItr; 
+      --masterItr;
       debugPrint(logger_, CTS, "tech char", 1, "updateBufferTopologies swap "
                  "from {} to {}, index:{}",
                  *(masterItr), newBufMaster->getName(), index);

src/cts/src/TechChar.h

@@ -134,7 +134,6 @@ class TechChar
   TechChar(CtsOptions* options,
            odb::dbDatabase* db,
            sta::dbSta* sta,
-           rsz::Resizer* resizer,
            est::EstimateParasitics* estimate_parasitics,
            sta::dbNetwork* db_network,
            utl::Logger* logger);

src/cts/src/TritonCTS.cpp

@@ -243,13 +243,8 @@ void TritonCTS::setupCharacterization()
   options_->setMaxWl(block_->micronsToDbu(maxWlMicrons));
 
   // A new characteriztion is always created.
-  techChar_ = std::make_unique<TechChar>(options_,
-                                         db_,
-                                         openSta_,
-                                         resizer_,
-                                         estimate_parasitics_,
-                                         network_,
-                                         logger_);
+  techChar_ = std::make_unique<TechChar>(
+      options_, db_, openSta_, estimate_parasitics_, network_, logger_);
   techChar_->create();
 
   // Also resets metrics everytime the setup is done

src/cts/test/cts_unittest.cc

@@ -79,8 +79,7 @@ TEST(SinkClusteringTest, ZeroHeightRegion)
   // Setup
   utl::Logger logger;
   CtsOptions options(&logger, nullptr);
-  TechChar techChar(
-      &options, nullptr, nullptr, nullptr, nullptr, nullptr, &logger);
+  TechChar techChar(&options, nullptr, nullptr, nullptr, nullptr, &logger);
   Clock net("clock", "clock", "clock", 0, 0);
   HTreeBuilder HTree(&options, net, nullptr, &logger, nullptr);
   SinkClustering clustering(&options, &techChar, &HTree);

src/dpl/src/Opendp.i

@@ -110,7 +110,7 @@ set_debug_cmd(float min_displacement,
   opendp->setDeepIterativePlacement(deep_iterative_placement);
   if (dpl::Graphics::guiActive()) {
       std::unique_ptr<DplObserver> graphics = std::make_unique<dpl::Graphics>(
-          opendp, min_displacement, debug_instance, paint_pixels);
+          opendp, debug_instance, paint_pixels);
       opendp->setDebug(graphics);
   }
 }

src/dpl/src/graphics/Graphics.cpp

@@ -19,7 +19,6 @@
 namespace dpl {
 
 Graphics::Graphics(Opendp* dp,
-                   float /*min_displacement not-used*/,
                    const odb::dbInst* debug_instance,
                    bool paint_pixels)
     : dp_(dp), debug_instance_(debug_instance), paint_pixels_(paint_pixels)

src/dpl/src/graphics/Graphics.h

@@ -20,7 +20,6 @@ class Graphics : public gui::Renderer, public DplObserver
 {
  public:
   Graphics(Opendp* dp,
-           float min_displacement,
            const odb::dbInst* debug_instance,
            bool paint_pixels = true);
   ~Graphics() override = default;

src/grt/src/cugr/src/CUGR.cpp

@@ -59,7 +59,6 @@ void CUGR::init(const int min_routing_layer,
 {
   design_ = std::make_unique<Design>(db_,
                                      logger_,
-                                     sta_,
                                      constants_,
                                      min_routing_layer,
                                      max_routing_layer,

src/grt/src/cugr/src/Design.cpp

@@ -19,7 +19,6 @@ namespace grt {
 
 Design::Design(odb::dbDatabase* db,
                utl::Logger* logger,
-               sta::dbSta* /*not-used*/,
                const Constants& constants,
                const int min_routing_layer,
                const int max_routing_layer,

src/grt/src/cugr/src/Design.h

@@ -35,7 +35,6 @@ class Design
  public:
   Design(odb::dbDatabase* db,
          utl::Logger* logger,
-         sta::dbSta* sta,
          const Constants& constants,
          int min_routing_layer,
          int max_routing_layer,