fix: code review

Signed-off-by: Tomas Weiss <[email protected]>

Author: tomkis

apps/agentstack-sdk-py/src/agentstack_sdk/a2a/extensions/services/form.py

@@ -41,13 +41,13 @@ def parse_initial_form(self, *, model: type[T] = FormResponse) -> T | None:
         if self.data is None:
             return None
 
-        intial_form = self.data.form_fulfillments["initial_form"]
+        initial_form = self.data.form_fulfillments.get("initial_form")
 
-        if intial_form is None:
+        if initial_form is None:
             return None
         if model is FormResponse:
-            return cast(T, intial_form)
-        return TypeAdapter(model).validate_python(dict(intial_form))
+            return cast(T, initial_form)
+        return TypeAdapter(model).validate_python(dict(initial_form))
 
 
 class FormServiceExtensionClient(BaseExtensionClient[FormServiceExtensionSpec, FormRender]): ...

apps/agentstack-ui/src/modules/runs/contexts/agent-demands/AgentDemandsProvider.tsx

@@ -4,7 +4,7 @@
  */
 
 import type { AgentSettings, FormFulfillments } from 'agentstack-sdk';
-import { type PropsWithChildren, useCallback, useEffect, useState } from 'react';
+import { type PropsWithChildren, useCallback, useEffect, useRef, useState } from 'react';
 
 import type { AgentA2AClient } from '#api/a2a/types.ts';
 import { useApp } from '#contexts/App/index.ts';
@@ -32,7 +32,7 @@ export function AgentDemandsProvider<UIGenericPart>({
 
   const [selectedEmbeddingProviders, setSelectedEmbeddingProviders] = useState<Record<string, string>>({});
   const [selectedLLMProviders, setSelectedLLMProviders] = useState<Record<string, string>>({});
-  const [formFulfillments, setFormFulfillments] = useState<FormFulfillments>({ form_fulfillments: {} });
+  const formFulfillmentsRef = useRef<FormFulfillments>({ form_fulfillments: {} });
 
   const [selectedSettings, setSelectedSettings] = useState<AgentSettings>(
     getSettingsDemandsDefaultValues(agentClient.demands.settingsDemands ?? { fields: [] }),
@@ -109,15 +109,14 @@ export function AgentDemandsProvider<UIGenericPart>({
     [setSelectedEmbeddingProviders],
   );
 
-  const provideFormValues = useCallback(
-    (values: RunFormValues) => {
-      setFormFulfillments((prev) => {
-        prev.form_fulfillments['initial_form'] = { values };
-        return prev;
-      });
-    },
-    [setFormFulfillments],
-  );
+  const provideFormValues = useCallback((values: RunFormValues) => {
+    formFulfillmentsRef.current = {
+      form_fulfillments: {
+        ...formFulfillmentsRef.current.form_fulfillments,
+        initial_form: { values },
+      },
+    };
+  }, []);
 
   const [selectedMCPServers, setSelectedMCPServers] = useState<Record<string, string>>({});
 
@@ -196,7 +195,7 @@ export function AgentDemandsProvider<UIGenericPart>({
         providedSecrets,
         featureFlags,
         selectedSettings,
-        formFulfillments,
+        formFulfillments: formFulfillmentsRef.current,
         oauthRedirectUri: fulfillmentsContext.oauthRedirectUri ?? null,
       });
     },
@@ -208,7 +207,6 @@ export function AgentDemandsProvider<UIGenericPart>({
       featureFlags,
       selectedSettings,
       demandedSecrets,
-      formFulfillments,
     ],
   );