fix(server): unit tests (#1729)

Signed-off-by: Radek Ježek <[email protected]>

Author: jezekra1

apps/agentstack-sdk-py/src/agentstack_sdk/platform/context.py

@@ -31,19 +31,15 @@ class ContextToken(pydantic.BaseModel):
     expires_at: pydantic.AwareDatetime | None = None
 
 
-class ResourceIdPermission(pydantic.BaseModel):
-    id: str
-
-
 class ContextPermissions(pydantic.BaseModel):
     files: set[Literal["read", "write", "extract", "*"]] = set()
     vector_stores: set[Literal["read", "write", "*"]] = set()
     context_data: set[Literal["read", "write", "*"]] = set()
 
 
 class Permissions(ContextPermissions):
-    llm: set[Literal["*"] | ResourceIdPermission] = set()
-    embeddings: set[Literal["*"] | ResourceIdPermission] = set()
+    llm: set[Literal["*"] | str] = set()
+    embeddings: set[Literal["*"] | str] = set()
     a2a_proxy: set[Literal["*"]] = set()
     model_providers: set[Literal["read", "write", "*"]] = set()
     variables: SerializeAsAny[set[Literal["read", "write", "*"]]] = set()

apps/agentstack-server/src/agentstack_server/api/schema/contexts.py

@@ -8,7 +8,6 @@
 from agentstack_server.api.schema.common import PaginationQuery
 from agentstack_server.domain.models.common import Metadata, MetadataPatch
 from agentstack_server.domain.models.context import ContextHistoryItemData
-from agentstack_server.domain.models.permissions import ResourceIdPermission
 
 
 class ContextCreateRequest(BaseModel):
@@ -47,8 +46,8 @@ class GlobalPermissionGrant(BaseModel):
     vector_stores: list[Literal["read", "write", "*"]] = Field(default_factory=list)
 
     # openai proxy
-    llm: list[Literal["*"] | ResourceIdPermission] = Field(default_factory=list)
-    embeddings: list[Literal["*"] | ResourceIdPermission] = Field(default_factory=list)
+    llm: list[Literal["*"] | str] = Field(default_factory=list)
+    embeddings: list[Literal["*"] | str] = Field(default_factory=list)
     model_providers: list[Literal["read", "write", "*"]] = Field(default_factory=list)
 
     a2a_proxy: list[Literal["*"]] = Field(default_factory=list)

apps/agentstack-server/src/agentstack_server/domain/models/permissions.py

@@ -9,11 +9,6 @@
 from agentstack_server.domain.models.user import User
 
 
-class ResourceIdPermission(BaseModel):
-    id: str
-    model_config = ConfigDict(frozen=True)
-
-
 class Permissions(BaseModel):
     model_config = ConfigDict(frozen=True, validate_default=True)
 
@@ -32,8 +27,8 @@ class Permissions(BaseModel):
 
     # openai proxy
     model_providers: SerializeAsAny[set[Literal["read", "write", "*"]]] = set()
-    llm: SerializeAsAny[set[Literal["*"] | ResourceIdPermission]] = set()
-    embeddings: SerializeAsAny[set[Literal["*"] | ResourceIdPermission]] = set()
+    llm: SerializeAsAny[set[Literal["*"] | str]] = set()
+    embeddings: SerializeAsAny[set[Literal["*"] | str]] = set()
 
     a2a_proxy: SerializeAsAny[set[Literal["*"]]] = set()
 

apps/agentstack-server/tasks.toml

@@ -8,6 +8,8 @@ sources = ["uv.lock", "pyproject.toml"]
 outputs = { auto = true }
 
 # check
+["agentstack-server:test"]
+depends = ["agentstack-server:test:unit"]
 
 ["agentstack-server:check"]
 depends = ["agentstack-server:check:*"]
@@ -248,6 +250,10 @@ run = "{{ mise_bin }} run agentstack-server:dev:disconnect --vm-name=agentstack-
 dir = "{{config_root}}/apps/agentstack-server"
 run = "{{ mise_bin }} run agentstack-server:dev:reconnect --vm-name=agentstack-local-test"
 
+["agentstack-server:test:unit"]
+dir = "{{config_root}}/apps/agentstack-server"
+run = "uv run pytest -m unit"
+
 ["agentstack-server:test:e2e"]
 dir = "{{config_root}}/apps/agentstack-server"
 run = """

apps/agentstack-server/tests/unit/domain/models/test_permissions.py

@@ -3,7 +3,7 @@
 
 import pytest
 
-from agentstack_server.domain.models.permissions import Permissions, ResourceIdPermission
+from agentstack_server.domain.models.permissions import Permissions
 
 pytestmark = pytest.mark.unit
 
@@ -86,8 +86,8 @@ def test_check_resource_id_wildcard():
 
 
 def test_check_resource_id_permissions():
-    resource1 = ResourceIdPermission(id="llm-1")
-    resource2 = ResourceIdPermission(id="llm-2")
+    resource1 = "llm-1"
+    resource2 = "llm-2"
 
     user_perms = Permissions(llm={resource1})
     required_perms = Permissions(llm={resource1})
@@ -170,8 +170,8 @@ def test_union_admin_permissions():
 
 
 def test_union_resource_id_permissions():
-    resource1 = ResourceIdPermission(id="llm-1")
-    resource2 = ResourceIdPermission(id="llm-2")
+    resource1 = "llm-1"
+    resource2 = "llm-2"
 
     perms1 = Permissions(llm={resource1})
     perms2 = Permissions(llm={resource2})

apps/agentstack-server/tests/unit/service_layer/services/test_model_provider_match.py

@@ -1,6 +1,8 @@
 # Copyright 2025 © BeeAI a Series of LF Projects, LLC
 # SPDX-License-Identifier: Apache-2.0
 
+from unittest.mock import Mock
+
 import pytest
 
 from agentstack_server.domain.models.model_provider import ModelCapability
@@ -14,7 +16,7 @@ class TestModelProviderMatchModels:
 
     def test_default_model_gets_exactly_half_score(self):
         """Test that default models get exactly 0.5 score."""
-        service = ModelProviderService(uow=None)  # We don't need UoW for internal method
+        service = ModelProviderService(uow=None, openai_proxy=Mock())  # We don't need UoW for internal method
 
         available_models = [
             "openai:gpt-4",
@@ -54,7 +56,7 @@ def test_default_model_gets_exactly_half_score(self):
 
     def test_exact_match_gets_score_of_one(self):
         """Test that exact matches get score of 1.0."""
-        service = ModelProviderService(uow=None)
+        service = ModelProviderService(uow=None, openai_proxy=Mock())
 
         available_models = ["openai:gpt-4", "openai:gpt-3.5-turbo", "anthropic:claude-3-5-sonnet"]
 
@@ -75,7 +77,7 @@ def test_exact_match_gets_score_of_one(self):
 
     def test_partial_match_gets_score_between_half_and_one(self):
         """Test that partial matches get scores between 0.5 and 1.0."""
-        service = ModelProviderService(uow=None)
+        service = ModelProviderService(uow=None, openai_proxy=Mock())
 
         available_models = [
             "openai:gpt-4",
@@ -98,7 +100,7 @@ def test_partial_match_gets_score_between_half_and_one(self):
 
     def test_no_match_below_cutoff_gets_no_score(self):
         """Test that matches below cutoff don't appear in results."""
-        service = ModelProviderService(uow=None)
+        service = ModelProviderService(uow=None, openai_proxy=Mock())
 
         available_models = ["openai:gpt-4", "anthropic:claude-3-5-sonnet"]
 
@@ -117,7 +119,7 @@ def test_no_match_below_cutoff_gets_no_score(self):
 
     def test_default_model_gets_max_of_default_and_fuzzy_score(self):
         """Test that default models get max of default score (0.5) and fuzzy match score."""
-        service = ModelProviderService(uow=None)
+        service = ModelProviderService(uow=None, openai_proxy=Mock())
 
         available_models = ["openai:gpt-4", "openai:gpt-3.5-turbo"]
 
@@ -151,7 +153,7 @@ def test_default_model_gets_max_of_default_and_fuzzy_score(self):
 
     def test_default_model_stays_exactly_half_when_no_fuzzy_match(self):
         """Test that default models stay at exactly 0.5 when there's no fuzzy matching improvement."""
-        service = ModelProviderService(uow=None)
+        service = ModelProviderService(uow=None, openai_proxy=Mock())
 
         available_models = [
             "openai:gpt-4",
@@ -183,7 +185,7 @@ def test_default_model_stays_exactly_half_when_no_fuzzy_match(self):
 
     def test_multiple_suggestions_best_match_wins(self):
         """Test that when multiple suggestions match, the best score is used."""
-        service = ModelProviderService(uow=None)
+        service = ModelProviderService(uow=None, openai_proxy=Mock())
 
         available_models = ["openai:gpt-4"]
 
@@ -205,7 +207,7 @@ def test_multiple_suggestions_best_match_wins(self):
 
     def test_results_sorted_by_score_descending(self):
         """Test that results are sorted by score in descending order."""
-        service = ModelProviderService(uow=None)
+        service = ModelProviderService(uow=None, openai_proxy=Mock())
 
         available_models = ["openai:gpt-4", "openai:gpt-3.5-turbo", "anthropic:claude-3-5-sonnet"]