fix: code review commennts

Signed-off-by: Tomas Weiss <[email protected]>

Author: tomkis

apps/beeai-ui/src/api/a2a/part-processors.ts

@@ -38,11 +38,7 @@ export function processMessageMetadata(message: Message): UIMessagePart[] {
     parts.push(...sourceParts);
   }
   if (form) {
-    const formPart = createFormPart(form);
-
-    if (formPart) {
-      parts.push(formPart);
-    }
+    return [createFormPart(form)];
   }
 
   return parts;

apps/beeai-ui/src/api/a2a/utils.ts

@@ -163,7 +163,7 @@ export function createTextPart(text: string): UITextPart {
   return textPart;
 }
 
-export function createFormPart(form: FormDemands): UIFormPart | null {
+export function createFormPart(form: FormDemands): UIFormPart {
   const formPart: UIFormPart = {
     kind: UIMessagePartKind.Form,
     ...form,

apps/beeai-ui/src/modules/compose/contexts/ComposeProvider.tsx

@@ -44,6 +44,10 @@ export function ComposeProvider({ children }: PropsWithChildren) {
     onStatusUpdate: handleTaskStatusUpdate,
   });
 
+  if (!agentClient) {
+    return <></>;
+  }
+
   return (
     <AgentDemandsProvider agentClient={agentClient}>
       <ComposeProviderWithContext agentClient={agentClient}>{children}</ComposeProviderWithContext>

apps/beeai-ui/src/modules/runs/components/RunInput.tsx

@@ -113,7 +113,7 @@ export function RunInput({ promptExamples, onMessageSent }: Props) {
 
             onMessageSent?.();
 
-            await chat(input, {});
+            await chat(input);
           })();
         }}
       >

apps/beeai-ui/src/modules/runs/contexts/agent-demands/AgentDemandsProvider.tsx

@@ -20,7 +20,7 @@ import { AgentDemandsContext } from './agent-demands-context';
 import { buildFulfillments } from './build-fulfillments';
 
 interface Props<UIGenericPart> {
-  agentClient?: AgentA2AClient<UIGenericPart>;
+  agentClient: AgentA2AClient<UIGenericPart>;
 }
 
 export function AgentDemandsProvider<UIGenericPart>({
@@ -31,7 +31,9 @@ export function AgentDemandsProvider<UIGenericPart>({
 
   const [selectedEmbeddingProviders, setSelectedEmbeddingProviders] = useState<Record<string, string>>({});
   const [selectedLLMProviders, setSelectedLLMProviders] = useState<Record<string, string>>({});
-  const [selectedSettings, setSelectedSettings] = useState<AgentSettings>({});
+  const [selectedSettings, setSelectedSettings] = useState<AgentSettings>(
+    getSettingsDemandsDefaultValues(agentClient.demands.settingsDemands ?? { fields: [] }),
+  );
 
   const {
     config: { featureFlags },
@@ -40,12 +42,6 @@ export function AgentDemandsProvider<UIGenericPart>({
 
   const { mutateAsync: createContextToken } = useCreateContextToken();
 
-  useEffect(() => {
-    if (agentClient?.demands.settingsDemands) {
-      setSelectedSettings(getSettingsDemandsDefaultValues(agentClient.demands.settingsDemands));
-    }
-  }, [agentClient?.demands.settingsDemands]);
-
   const onUpdateSettings = useCallback((value: AgentSettings) => {
     setSelectedSettings(value);
   }, []);

apps/beeai-ui/src/modules/runs/contexts/agent-run/AgentRunProvider.tsx

@@ -55,6 +55,10 @@ export function AgentRunProviders({ agent, children }: PropsWithChildren<Props>)
 
   useEnsurePlatformContext(agent);
 
+  if (!agentClient) {
+    return <></>;
+  }
+
   return (
     <AgentSecretsProvider agent={agent} agentClient={agentClient}>
       <AgentDemandsProvider agentClient={agentClient}>
@@ -278,7 +282,7 @@ function AgentRunProvider({ agent, agentClient, children }: PropsWithChildren<Ag
   );
 
   const chat = useCallback(
-    (input: string, fulfillmentsContext: FulfillmentsContext) => {
+    (input: string, fulfillmentsContext: FulfillmentsContext = {}) => {
       checkPendingRun();
       cancelPendingTask();
 

apps/beeai-ui/src/modules/runs/contexts/agent-run/agent-run-context.ts

@@ -25,7 +25,7 @@ interface AgentRunContextValue {
   input?: string;
   stats?: RunStats;
   hasMessages: boolean;
-  chat: (input: string, fulfillmentsContext: FulfillmentsContext) => Promise<void>;
+  chat: (input: string, fulfillmentsContext?: FulfillmentsContext) => Promise<void>;
   submitForm: (form: UIMessageForm) => Promise<void>;
   submitRuntimeForm: (form: UIMessageForm, taskId: TaskId) => Promise<void>;
   startAuth: (url: string, taskId: TaskId) => void;