fix: code review improvements

Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com>

Author: tomkis

apps/agentstack-server/src/agentstack_server/domain/repositories/user_feedback.py

@@ -14,7 +14,7 @@ async def create(self, *, user_feedback: UserFeedback) -> None: ...
     async def list(
         self,
         *,
-        user_id: UUID | None = None,
+        provider_created_by: UUID | None = None,
         provider_id: UUID | None = None,
         limit: int = 50,
         after_cursor: UUID | None = None,

apps/agentstack-server/src/agentstack_server/infrastructure/persistence/repositories/user_feedback.py

@@ -56,7 +56,7 @@ async def create(self, *, user_feedback: UserFeedback) -> None:
     async def list(
         self,
         *,
-        user_id: UUID | None = None,
+        provider_created_by: UUID | None = None,
         provider_id: UUID | None = None,
         limit: int = 50,
         after_cursor: UUID | None = None,
@@ -66,8 +66,8 @@ async def list(
             providers_table.c.agent_card["name"].label("agent_name"),
         ).join(providers_table, user_feedback_table.c.provider_id == providers_table.c.id)
 
-        if user_id is not None:
-            query = query.where(providers_table.c.created_by == user_id)
+        if provider_created_by is not None:
+            query = query.where(providers_table.c.created_by == provider_created_by)
 
         if provider_id is not None:
             query = query.where(user_feedback_table.c.provider_id == provider_id)

apps/agentstack-server/src/agentstack_server/service_layer/services/user_feedback.py

@@ -61,11 +61,14 @@ async def list_user_feedback(
         limit: int = 50,
         after_cursor: UUID | None = None,
     ) -> tuple[list[UserFeedback], int, bool]:
-        user_id = user.id if user.role != UserRole.ADMIN else None
+        if user.role not in (UserRole.ADMIN, UserRole.DEVELOPER):
+            raise ValueError("Listing feedback is only allowed for admins and developers")
+
+        provider_created_by = user.id if user.role == UserRole.DEVELOPER else None
 
         async with self._uow() as uow:
             feedback_list, total, has_more = await uow.user_feedback.list(
-                user_id=user_id,
+                provider_created_by=provider_created_by,
                 provider_id=provider_id,
                 limit=limit,
                 after_cursor=after_cursor,