Disable ‘checkPackage’ for Debian by default

It does produce more problems than solutions. Especially since we’re currently not fullfilling the requirements of lintian and there is no way for a user to make sure they are.

Author: gamma

src/com/inet/gradle/setup/unix/deb/Deb.java

@@ -21,22 +21,22 @@
 
 /**
  * The deb Gradle task. It build a deb package for Debian / Ubuntu.
- * 
+ *
  * @author Stefan Heidrich
  */
 public class Deb extends Unix {
 
-    private String priority;
+    private String  priority;
 
-    private String installSize;
+    private String  installSize;
 
-    private String recommends;
+    private String  recommends;
 
-    private String checkPackage;
+    private boolean checkPackage = false;
 
-    private String maintainerEmail;
+    private String  maintainerEmail;
 
-    private String changes;
+    private String  changes;
 
     public Deb() {
         super( "deb" );
@@ -67,19 +67,21 @@ public void setInstallSize( String installSize ) {
         this.installSize = installSize;
     }
 
+    @Override
     public String getRecommends() {
         return recommends;
     }
 
+    @Override
     public void setRecommends( String recommends ) {
         this.recommends = recommends;
     }
 
-    public String getCheckPackage() {
+    public boolean shouldCheckPackage() {
         return checkPackage;
     }
 
-    public void setCheckPackage( String checkPackage ) {
+    public void setCheckPackage( boolean checkPackage ) {
         this.checkPackage = checkPackage;
     }
 

src/com/inet/gradle/setup/unix/deb/DebBuilder.java

@@ -45,7 +45,7 @@ public class DebBuilder extends AbstractBuilder<Deb, SetupBuilder> {
 
     /**
      * Create a new instance
-     * 
+     *
      * @param deb
      *            the calling task
      * @param setup
@@ -241,7 +241,7 @@ private void setupEula() throws IOException {
 
     /**
      * Creates the files and the corresponding script section for the specified service.
-     * 
+     *
      * @param service
      *            the service
      * @throws IOException
@@ -272,7 +272,7 @@ private void setupService( Service service ) throws IOException {
         String initScriptFile = "etc/init.d/" + serviceUnixName;
         initScript.writeTo( createFile( initScriptFile, true ) );
 
-        // copy a default service file if set 
+        // copy a default service file if set
         if( task.getDefaultServiceFile() != null ) {
             File serviceDestFile = new File( buildDir.getAbsolutePath(), "/etc/default/" + serviceUnixName );
             serviceDestFile.mkdirs();
@@ -290,7 +290,7 @@ private void setupService( Service service ) throws IOException {
 
     /**
      * Creates the files and the corresponding scripts for the specified desktop starter.
-     * 
+     *
      * @param starter
      *            the desktop starter
      * @throws IOException
@@ -316,7 +316,7 @@ private void setupStarter( DesktopStarter starter ) throws IOException {
             if( index > -1 ) {
                 iconName = iconName.substring( index + 1 );
             }
-            // icons must be png files and should named like that 
+            // icons must be png files and should named like that
             if( !iconName.endsWith( ".png" ) ) {
                 index = iconName.lastIndexOf( '.' );
                 if( index > -1 ) {
@@ -366,7 +366,7 @@ private void setupStarter( DesktopStarter starter ) throws IOException {
                 if( cwd.isEmpty() || cwd.equals( "." )) {
                     fw.write( "Path=" + task.getInstallationRoot() + "\n" );
                 } else {
-                    fw.write( "Path=" + cwd + "\n" );    
+                    fw.write( "Path=" + cwd + "\n" );
                 }
             }
             fw.write( "Terminal=false\n" );
@@ -393,14 +393,14 @@ private void setupStarter( DesktopStarter starter ) throws IOException {
                     if( starter.getMimeTypes() != null ) {
                         fw.write( "    <mime-type type=\"" + starter.getMimeTypes() + "\">\n" );
                     } else {
-                        fw.write( "    <mime-type type=\"" + docType.getMimetype() + "\">\n" );                        
+                        fw.write( "    <mime-type type=\"" + docType.getMimetype() + "\">\n" );
                     }
 
                     fw.write( "        <comment>" + setup.getApplication() + "</comment>\n" );
                     fw.write( "        <glob-deleteall/>\n" );
                     fw.write( "        <glob pattern=\"*." + extension + "\"/>\n" );
                     fw.write( "    </mime-type>\n" );
-                    fw.write( "</mime-info>\n" );                    
+                    fw.write( "</mime-info>\n" );
                 }
 
                 controlBuilder.addTailScriptFragment( Script.POSTINST, "xdg-mime install \"" + task.getInstallationRoot() + "/" + simpleVendor + "-" + extension + ".xml\" || true" );
@@ -431,7 +431,7 @@ private void setupStarter( DesktopStarter starter ) throws IOException {
 
     /**
      * Creates a file in the build path structure.
-     * 
+     *
      * @param path
      *            the path relative to the root of the build path
      * @param executable
@@ -456,7 +456,7 @@ private File createFile( String path, boolean executable ) throws IOException {
      * property is set to true
      */
     private void checkDebianPackage() {
-        if( task.getCheckPackage() == null || task.getCheckPackage().equalsIgnoreCase( "true" ) ) {
+        if( task.shouldCheckPackage() ) {
             ArrayList<String> command = new ArrayList<>();
             command.add( "lintian" );
 //            command.add( "-d" );
@@ -490,7 +490,7 @@ private void createDebianPackage() {
 
     /**
      * Changes the permissions of all directories recursively inside the specified path to 755.
-     * 
+     *
      * @param path
      *            the path
      * @throws IOException
@@ -508,7 +508,7 @@ private void changeDirectoryPermissionsTo755( File path ) throws IOException {
 
     /**
      * Changes the permissions of all files recursively inside the specified path to 644.
-     * 
+     *
      * @param path
      *            the path
      * @throws IOException