Skip to content

Commit a48c333

Browse files
Localized some missing strings
1 parent fcf9236 commit a48c333

File tree

8 files changed

+21
-10
lines changed

8 files changed

+21
-10
lines changed

Movie DB/Localization/Strings+Generic.swift

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,5 +99,9 @@ extension Strings {
9999
localized: "generic.editButtonEdit",
100100
comment: "The edit button label displayed while not in editing mode"
101101
)
102+
static let dismissViewDone = String(
103+
localized: "generic.dismissViewDone",
104+
comment: "The done button to dismiss a view (e.g. a popup or sheet view)"
105+
)
102106
}
103107
}

Movie DB/Localization/Strings+Lists.swift

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,5 +142,10 @@ extension Strings {
142142
localized: "lists.root.placeholder",
143143
comment: "The placeholder text displayed in the middle column of the lists view when no list is selected."
144144
)
145+
146+
static let configureListLabel = String(
147+
localized: "lists.detail.configure",
148+
comment: "The button label for the toolbar button to configure an opened view."
149+
)
145150
}
146151
}

Movie DB/Localization/de.lproj/Localizable.strings

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -815,3 +815,5 @@
815815
"library.detailPlaceholder" = "Medium auswählen";
816816
"generic.editButtonDone" = "Fertig";
817817
"generic.editButtonEdit" = "Bearbeiten";
818+
"generic.dismissViewDone" = "Fertig";
819+
"lists.detail.configure" = "Konfigurieren...";

Movie DB/Localization/en.lproj/Localizable.strings

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -821,3 +821,5 @@
821821
"library.detailPlaceholder" = "Select a media";
822822
"generic.editButtonDone" = "Done";
823823
"generic.editButtonEdit" = "Edit";
824+
"generic.dismissViewDone" = "Done";
825+
"lists.detail.configure" = "Configure...";

Movie DB/Views/Component Views/ListConfigurationButton.swift

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,7 @@ struct ListConfigurationButton: View {
1919
Button {
2020
isShowing = true
2121
} label: {
22-
// TODO: Localize
23-
Text("Configure...")
22+
Text(Strings.Lists.configureListLabel)
2423
}
2524
}
2625
}

Movie DB/Views/Detail/MediaDetail.swift

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,7 @@ struct MediaDetail: View {
4545
}
4646
.toolbar {
4747
ToolbarItem(placement: .navigationBarTrailing) {
48-
// TODO: Localize
49-
Button(isEditing ? "Done" : "Edit") {
48+
Button(isEditing ? Strings.Generic.editButtonLabelDone : Strings.Generic.editButtonLabelEdit) {
5049
withAnimation(.easeInOut) {
5150
isEditing.toggle()
5251
}

Movie DB/Views/Library/LibraryHome.swift

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -73,9 +73,9 @@ struct LibraryHome: View {
7373
.sheet(item: $activeSheet) { sheet in
7474
switch sheet {
7575
case .addMedia:
76+
// FUTURE: Open new item in editing mode
7677
AddMediaView()
7778
.environment(\.managedObjectContext, managedObjectContext)
78-
// FUTURE: Open new item in editing mode
7979
case .filter:
8080
FilterView(filterSetting: filterSetting)
8181
.environment(\.managedObjectContext, managedObjectContext)
@@ -102,9 +102,10 @@ struct LibraryHome: View {
102102
Image(systemName: "ellipsis.circle")
103103
}
104104
}
105-
ToolbarItem(placement: .navigationBarTrailing) {
106-
EditButton()
107-
}
105+
// Reactivate when actions and multiselection is implemented
106+
// ToolbarItem(placement: .navigationBarTrailing) {
107+
// EditButton()
108+
// }
108109
ToolbarItem(placement: .navigationBarTrailing) {
109110
Button {
110111
self.activeSheet = .addMedia

Movie DB/Views/MediaLists/ListConfigurationView.swift

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,7 @@ struct ListConfigurationView<ListType, Content: View>: View where ListType: Medi
2222
.navigationTitle(list.name)
2323
.navigationBarTitleDisplayMode(.inline)
2424
.toolbar {
25-
// TODO: Localize
26-
Button("Done") {
25+
Button(Strings.Generic.dismissViewDone) {
2726
dismiss()
2827
}
2928
}

0 commit comments

Comments
 (0)