Use utility function everywhere

Author: zguesmi

test/000_fullchain-boost.test.ts

@@ -37,6 +37,7 @@ import {
 } from '../utils/poco-tools';
 import { IexecWrapper } from './utils/IexecWrapper';
 import { loadHardhatFixtureDeployment } from './utils/hardhat-fixture-deployer';
+import { randomAddress } from './utils/utils';
 
 const teeDealTag = '0x0000000000000000000000000000000000000000000000000000000000000001';
 const taskIndex = 0n;
@@ -129,7 +130,7 @@ describe('IexecPocoBoostFacet (IT)', function () {
 
     describe('MatchOrders', function () {
         it('Should match orders (TEE)', async function () {
-            const callbackAddress = ethers.Wallet.createRandom().address;
+            const callbackAddress = randomAddress();
             const orders = buildOrders({
                 assets: ordersAssets,
                 requester: requester.address,
@@ -288,7 +289,7 @@ describe('IexecPocoBoostFacet (IT)', function () {
         });
 
         it('Should sponsor match orders (TEE)', async function () {
-            const callbackAddress = ethers.Wallet.createRandom().address;
+            const callbackAddress = randomAddress();
             const orders = buildOrders({
                 assets: ordersAssets,
                 requester: requester.address,

test/000_fullchain.test.ts

@@ -16,6 +16,7 @@ import {
 } from '../utils/poco-tools';
 import { IexecWrapper } from './utils/IexecWrapper';
 import { loadHardhatFixtureDeployment } from './utils/hardhat-fixture-deployer';
+import { randomAddress } from './utils/utils';
 
 //  +---------+-------------+-------------+-------------+----------+-----+---------------------------------------------+
 //  |         | Sponsorship | Replication | Beneficiary | Callback | BoT |              Type                           |
@@ -34,7 +35,7 @@ const teeDealTag = '0x0000000000000000000000000000000000000000000000000000000000
 const appPrice = 1000n;
 const datasetPrice = 1_000_000n;
 const workerpoolPrice = 1_000_000_000n;
-const callbackAddress = ethers.Wallet.createRandom().address;
+const callbackAddress = randomAddress();
 const { results, resultDigest } = buildUtf8ResultAndDigest('result');
 const { resultsCallback, callbackResultDigest } = buildResultCallbackAndDigest(123);
 

test/byContract/IexecAccessors/IexecAccessors.test.ts

@@ -28,7 +28,7 @@ import {
 } from '../../../utils/poco-tools';
 import { IexecWrapper } from '../../utils/IexecWrapper';
 import { loadHardhatFixtureDeployment } from '../../utils/hardhat-fixture-deployer';
-import { hashDomain } from '../../utils/utils';
+import { hashDomain, randomAddress } from '../../utils/utils';
 
 /**
  * Test state view functions.
@@ -104,7 +104,7 @@ describe('IexecAccessors', async () => {
 
     it('allowance', async function () {
         const amount = 10n;
-        const spender = ethers.Wallet.createRandom().address;
+        const spender = randomAddress();
         await iexecWrapper.depositInIexecAccount(anyone, amount);
         await iexecPoco.connect(anyone).approve(spender, amount);
         expect(await iexecPoco.allowance(anyone.address, spender)).to.equal(amount);

test/byContract/IexecPocoBoost/IexecPocoBoost.test.ts

@@ -58,6 +58,7 @@ import {
 } from '../../../utils/poco-tools';
 import { IexecWrapper } from '../../utils/IexecWrapper';
 import { loadHardhatFixtureDeployment } from '../../utils/hardhat-fixture-deployer';
+import { randomAddress } from '../../utils/utils';
 
 const teeDealTag = '0x0000000000000000000000000000000000000000000000000000000000000001';
 const taskIndex = 0n;
@@ -69,7 +70,7 @@ const appPrice = 1000n;
 const datasetPrice = 1_000_000n;
 const workerpoolPrice = 1_000_000_000n;
 const someSignature = '0xabcd'; // contract signatures could have arbitrary formats
-const randomEOAAddress = ethers.Wallet.createRandom().address;
+const randomEOAAddress = randomAddress();
 
 let proxyAddress: string;
 let iexecPocoBoostInstance: IexecPocoBoostFacet;
@@ -173,7 +174,7 @@ describe('IexecPocoBoost', function () {
                 beneficiary: beneficiary.address,
                 tag: teeDealTag,
                 prices: ordersPrices,
-                callback: ethers.Wallet.createRandom().address,
+                callback: randomAddress(),
             });
             const {
                 appOrder,
@@ -304,7 +305,7 @@ describe('IexecPocoBoost', function () {
                 beneficiary: beneficiary.address,
                 tag: teeDealTag,
                 prices: ordersPrices,
-                callback: ethers.Wallet.createRandom().address,
+                callback: randomAddress(),
             });
             const { appOrder, datasetOrder, workerpoolOrder, requestOrder } = orders.toObject();
             // Should match orders with low app order volume
@@ -1618,7 +1619,7 @@ describe('IexecPocoBoost', function () {
                 assets: ordersAssets,
                 requester: requester.address,
                 tag: teeDealTag,
-                callback: ethers.Wallet.createRandom().address,
+                callback: randomAddress(),
             });
             await signOrders(domain, orders, ordersActors);
             const dealId = getDealId(domain, orders.requester, taskIndex);
@@ -1971,7 +1972,7 @@ describe('IexecPocoBoost', function () {
                 assets: ordersAssets,
                 requester: requester.address,
                 tag: teeDealTag,
-                callback: ethers.Wallet.createRandom().address,
+                callback: randomAddress(),
             });
             await signOrders(domain, orders, ordersActors);
             const dealId = getDealId(domain, orders.requester, taskIndex);

test/byContract/IexecRelay/IexecRelay.test.ts

@@ -11,6 +11,7 @@ import {
 } from '../../../typechain';
 import { getIexecAccounts } from '../../../utils/poco-tools';
 import { loadHardhatFixtureDeployment } from '../../utils/hardhat-fixture-deployer';
+import { randomAddress } from '../../utils/utils';
 
 const appPrice = 1;
 const datasetPrice = 2;
@@ -35,9 +36,7 @@ describe('IexecRelay', async () => {
     async function initFixture() {
         const accounts = await getIexecAccounts();
         iexecPoco = IexecInterfaceNative__factory.connect(proxyAddress, accounts.anyone);
-        [app, dataset, workerpool, requester, beneficiary] = Array(5).fill(
-            ethers.Wallet.createRandom().address,
-        );
+        [app, dataset, workerpool, requester, beneficiary] = Array(5).fill(randomAddress());
         sign = await ethers.Wallet.createRandom().signMessage('sign');
     }
 
@@ -108,7 +107,7 @@ describe('IexecRelay', async () => {
             category,
             trust,
             beneficiary,
-            callback: ethers.Wallet.createRandom().address,
+            callback: randomAddress(),
             params: 'params',
             salt,
             sign,