fix: Fix set-callback-gas script (#270)

Author: zguesmi

README.md

@@ -37,8 +37,7 @@ This repository contains the smart contract implementation of iExec's PoCo proto
 ## Documentation
 
 - [Solidity API documentation](./docs/solidity/index.md)
-<!-- TODO update with new documentation URL -->
-- [Full PoCo documentation](https://protocol.docs.iex.ec/key-concepts/proof-of-contribution)
+- [Full PoCo documentation](https://docs.iex.ec/protocol/proof-of-contribution)
 
 ## Audits
 

deploy/0_deploy.ts

@@ -229,7 +229,12 @@ export default async function deploy() {
         deployer,
         ownerAddress,
     );
-    if (network.name !== 'hardhat' && network.name !== 'localhost') {
+    // Verify contracts if not on a development network.
+    if (
+        !['hardhat', 'localhost', 'external-hardhat', 'dev-native', 'dev-token'].includes(
+            network.name,
+        )
+    ) {
         console.log('Waiting for block explorer to index the contracts...');
         await new Promise((resolve) => setTimeout(resolve, 60000));
         await import('../scripts/verify').then((module) => module.default());

scripts/set-callback-gas.ts

@@ -1,25 +1,35 @@
 // SPDX-FileCopyrightText: 2024-2025 IEXEC BLOCKCHAIN TECH <[email protected]>
 // SPDX-License-Identifier: Apache-2.0
 
-import { deployments, ethers } from 'hardhat';
-import { IexecAccessors__factory, IexecConfigurationFacet__factory } from '../typechain';
+// Usage: CALLBACK_GAS=<value> npx hardhat run scripts/set-callback-gas.ts --network <network>
+
+import { ethers } from 'hardhat';
+import { IexecInterfaceToken__factory } from '../typechain';
+import config from '../utils/config';
 
 (async () => {
     const requestedCallbackGas = Number(process.env.CALLBACK_GAS);
     if (!requestedCallbackGas) {
-        console.error('`CALLBACK_GAS` env variable is missing. Aborting.');
-        process.exit(1);
+        throw new Error('`CALLBACK_GAS` env variable is missing or invalid.');
     }
-    console.log(`Setting callback-gas to ${requestedCallbackGas.toLocaleString()} ..`);
+    const { chainId, name: chainName } = await ethers.provider.getNetwork();
+    console.log(`Network: ${chainName} (${chainId})`);
+    const proxyAddress = config.getChainConfig(chainId).v5.DiamondProxy;
+    if (!proxyAddress) {
+        throw new Error('Diamond proxy address is required');
+    }
+    console.log(`Diamond proxy address: ${proxyAddress}`);
     const [owner] = await ethers.getSigners();
-    const diamondProxyAddress = (await deployments.get('Diamond')).address;
-    const viewCallbackGas = async () =>
-        (await IexecAccessors__factory.connect(diamondProxyAddress, owner).callbackgas())
-            .toNumber()
-            .toLocaleString();
-    const callbackGasBefore = await viewCallbackGas();
-    await IexecConfigurationFacet__factory.connect(diamondProxyAddress, owner)
-        .setCallbackGas(requestedCallbackGas)
-        .then((tx) => tx.wait());
-    console.log(`Changed callback-gas from ${callbackGasBefore} to ${await viewCallbackGas()}`);
-})().catch((error) => console.log(error));
+    const iexecPoCo = IexecInterfaceToken__factory.connect(proxyAddress, owner);
+    if ((await iexecPoCo.owner()) !== owner.address) {
+        throw new Error(`Sender account ${owner.address} is not the PoCo owner.`);
+    }
+    console.log(`Setting callback-gas to ${requestedCallbackGas.toLocaleString()} ..`);
+    const callbackGasBefore = (await iexecPoCo.callbackgas()).toLocaleString();
+    await iexecPoCo.setCallbackGas(requestedCallbackGas).then((tx) => tx.wait());
+    const callbackGasAfter = (await iexecPoCo.callbackgas()).toLocaleString();
+    console.log(`Changed callback-gas from ${callbackGasBefore} to ${callbackGasAfter}`);
+})().catch((error) => {
+    console.log(error);
+    process.exitCode = 1;
+});