Fix #20 add range on trust param 0- 100

Author: francois branciard

ChangeLog.md

@@ -9,7 +9,7 @@ Features:
 
 Bugfixes:
  * [#15](https://github.com/iExecBlockchainComputing/PoCo/issues/15): Malicious IexecAPI contract without callback                       [PLANNED in v1.0.13]
- * [#20](https://github.com/iExecBlockchainComputing/PoCo/issues/20): add range on trust param ( 0- n ) and check it in contracts        [PLANNED in v1.0.13]
+
 
 ### v1.0.13 (unreleased)
 
@@ -19,6 +19,7 @@ Features:
 
 Bugfixes:
 * [#24](https://github.com/iExecBlockchainComputing/PoCo/issues/24) possibly useless RLC address getter
+* [#20](https://github.com/iExecBlockchainComputing/PoCo/issues/20): add range on trust param ( 0- 100 ) and check it in contracts
 
 
 ### [v1.0.12](https://github.com/iExecBlockchainComputing/PoCo/releases/tag/v1.0.12)

contracts/Marketplace.sol

@@ -47,6 +47,7 @@ contract Marketplace is IexecHubAccessor
 	{
 		require(iexecHubInterface.existingCategory(_category));
 		require(_volume >0);
+		require(_trust <=100);
 		m_orderCount = m_orderCount.add(1);
 		IexecLib.MarketOrder storage marketorder    = m_orderBook[m_orderCount];
 		marketorder.direction      = _direction;

test/byFunctions/Marketplace/createMarketOrder.js

@@ -478,7 +478,7 @@ contract('IexecHub', function(accounts) {
   });
 
   it("createMarketOrder_10 : a owner (scheduleProvider) of worker pool can't emit a ASK Market Order with volume = 0", async function() {
-    await Extensions.expectedExceptionPromise(() => {
+    return await Extensions.expectedExceptionPromise(() => {
         return aMarketplaceInstance.createMarketOrder(
           constants.MarketOrderDirectionEnum.ASK,
           1 /*_category*/ ,
@@ -599,9 +599,48 @@ contract('IexecHub', function(accounts) {
 
   });
 
-  /*
-  TODO trust value tests ?
-  */
+  it("createMarketOrder_13 : a owner (scheduleProvider) of worker pool can emit with _trust <= 100 ", async function() {
+
+    txMined = await aMarketplaceInstance.createMarketOrder(
+      constants.MarketOrderDirectionEnum.ASK,
+      1 /*_category*/ ,
+      100 /*_trust*/ ,
+      0 /*_value*/ ,
+      workerPoolAddress /*_workerpool of scheduler*/ ,
+      1 /*_volume*/ , {
+        from: scheduleProvider
+      });
+
+    events = await Extensions.getEventsPromise(aMarketplaceInstance.MarketOrderCreated({}), 1, constants.EVENT_WAIT_TIMEOUT);
+    assert.strictEqual(events[0].args.marketorderIdx.toNumber(), 1, "marketorderIdx");
+
+    [direction, category, trust, value, volume, remaining, workerpool, workerpoolOwner] = await aMarketplaceInstance.getMarketOrder.call(1);
+    assert.strictEqual(direction.toNumber(), constants.MarketOrderDirectionEnum.ASK, "check constants.MarketOrderDirectionEnum.ASK");
+    assert.strictEqual(category.toNumber(), 1, "check category");
+    assert.strictEqual(trust.toNumber(), 100, "check trust 100");
+    assert.strictEqual(value.toNumber(), 0, "check value");
+    assert.strictEqual(volume.toNumber(), 1, "check volume");
+    assert.strictEqual(remaining.toNumber(), 1, "check remaining");
+    assert.strictEqual(workerpool, workerPoolAddress, "check workerpool");
+    assert.strictEqual(workerpoolOwner, scheduleProvider, "check workerpoolOwner");
+
+    return await Extensions.expectedExceptionPromise(() => {
+          return aMarketplaceInstance.createMarketOrder(
+            constants.MarketOrderDirectionEnum.ASK,
+            1 /*_category*/ ,
+            101 /*_trust*/ ,
+            0 /*_value*/ ,
+            workerPoolAddress /*_workerpool of scheduler*/ ,
+            1 /*_volume*/ , {
+              from: scheduleProvider,
+              gas: constants.AMOUNT_GAS_PROVIDED
+            });
+        },
+        constants.AMOUNT_GAS_PROVIDED);
+
+
+  });
+
 
 
 });