fix: update deposit function to override and adjust balance verification in tests

Author: gfournierPro

contracts/facets/IexecEscrowTokenFacet.sol

@@ -110,7 +110,7 @@ contract IexecEscrowTokenFacet is IexecEscrowToken, IexecTokenSpender, FacetBase
         uint256 amount,
         address token,
         bytes calldata data
-    ) external returns (bool) {
+    ) external override returns (bool) {
         PocoStorageLib.PocoStorage storage $ = PocoStorageLib.getPocoStorage();
         require(token == address($.m_baseToken), "wrong-token");
         _deposit(sender, amount);

test/byContract/IexecEscrow/IexecEscrowToken.receiveApproval.test.ts

@@ -203,15 +203,11 @@ describe('IexecEscrowToken-receiveApproval', () => {
                     volume,
                 );
 
-            // Verify frozen balance
-            expect(await iexecPoco.frozenOf(requester.address)).to.equal(dealCost);
-
             // Verify total supply increased
             expect(await iexecPoco.totalSupply()).to.equal(initialTotalSupply + dealCost);
-            // Total balance should be existing + new deposit - frozen
-            expect(await iexecPoco.balanceOf(requester.address)).to.equal(
-                initialBalance + dealCost - dealCost,
-            );
+            // The available balance remains unchanged because the deposit is immediately frozen
+            expect(await iexecPoco.balanceOf(requester.address)).to.equal(initialBalance);
+            // Verify frozen balance
             expect(await iexecPoco.frozenOf(requester.address)).to.equal(dealCost);
         });
 
@@ -290,14 +286,10 @@ describe('IexecEscrowToken-receiveApproval', () => {
 
             const initialBalance = await iexecPoco.balanceOf(requester.address);
             const encodedOrders = encodeOrdersForCallback(orders);
-            const dealId = getDealId(iexecWrapper.getDomain(), orders.requester);
-
-            const tx = rlcInstanceAsRequester.approveAndCall(proxyAddress, dealCost, encodedOrders);
+            await rlcInstanceAsRequester.approveAndCall(proxyAddress, dealCost, encodedOrders);
 
-            // Total balance should be existing + new deposit - frozen
-            expect(await iexecPoco.balanceOf(requester.address)).to.equal(
-                initialBalance + dealCost - dealCost,
-            );
+            // The available balance remains unchanged because the deposit is immediately frozen
+            expect(await iexecPoco.balanceOf(requester.address)).to.equal(initialBalance);
             expect(await iexecPoco.frozenOf(requester.address)).to.equal(dealCost);
         });
 
@@ -438,9 +430,12 @@ describe('IexecEscrowToken-receiveApproval', () => {
 
             const dealCost = 0n;
             const encodedOrders = encodeOrdersForCallback(ordersZeroPrice);
-            const dealId = getDealId(iexecWrapper.getDomain(), ordersZeroPrice.requester);
 
-            const tx = rlcInstanceAsRequester.approveAndCall(proxyAddress, dealCost, encodedOrders);
+            const tx = await rlcInstanceAsRequester.approveAndCall(
+                proxyAddress,
+                dealCost,
+                encodedOrders,
+            );
 
             await expect(tx)
                 .to.emit(iexecPoco, 'Transfer')