Merge pull request #36 from iExecBlockchainComputing/v1.0.13

V1.0.13

Author: fbranciard

ChangeLog.md

@@ -0,0 +1,35 @@
+
+
+### backlog
+Features:
+ * [#17](https://github.com/iExecBlockchainComputing/PoCo/issues/17): do not revert bad reveal but store it to a wrong status            [POST V2]
+ * [#19](https://github.com/iExecBlockchainComputing/PoCo/issues/19): MarketOrder (Direction & Status)                                   [GO/NOGO]
+ * [#22](https://github.com/iExecBlockchainComputing/PoCo/issues/22): allow to deposit on someone else's account                         [GO/NOGO]
+ * [#23](https://github.com/iExecBlockchainComputing/PoCo/issues/23): rename createMarketOrder => createOrder || createWorkOrder         [GO/NOGO]
+
+Bugfixes:
+
+
+### v1.0.13 (unreleased)
+
+Features:
+ * [#16](https://github.com/iExecBlockchainComputing/PoCo/issues/16) add counters info in Hub
+ * [#21](https://github.com/iExecBlockchainComputing/PoCo/issues/21): remove change ownership in OwnableOZ.sol   
+
+Bugfixes:
+* [#24](https://github.com/iExecBlockchainComputing/PoCo/issues/24) : possibly useless RLC address getter
+* [#15](https://github.com/iExecBlockchainComputing/PoCo/issues/15) :[CS AUDIT] Result without Payment. Malicious IexecAPI contract without callback
+* [#25](https://github.com/iExecBlockchainComputing/PoCo/issues/25) :[CS AUDIT] Scheduler can manipulate its reward percentage
+* [#26](https://github.com/iExecBlockchainComputing/PoCo/issues/26) :[CS AUDIT] Arbitrary Contract are trusted
+* [#27](https://github.com/iExecBlockchainComputing/PoCo/issues/27) :[CS AUDIT] fix consensusTimout, failled typo to consensusTimeout, failed
+* [#28](https://github.com/iExecBlockchainComputing/PoCo/issues/28) : Attacker can race to attach invalid hubs.
+* [#29](https://github.com/iExecBlockchainComputing/PoCo/issues/29) : [CS AUDIT] Addresses are are duplicates
+* [#30](https://github.com/iExecBlockchainComputing/PoCo/issues/30) : IexecHubInterface is not up to date
+* [#31](https://github.com/iExecBlockchainComputing/PoCo/issues/31) : OwnableOZ event not correct
+* [#32](https://github.com/iExecBlockchainComputing/PoCo/issues/32) : Need more gas
+* [#33](https://github.com/iExecBlockchainComputing/PoCo/issues/33) : [CS AUDIT] Both a contract and an event are called WorkOrder.
+* [#34](https://github.com/iExecBlockchainComputing/PoCo/issues/34) : [CS AUDIT] the variable names workerReward and workersReward are confusingly similar
+
+
+### [v1.0.12](https://github.com/iExecBlockchainComputing/PoCo/releases/tag/v1.0.12)
+Initial version. external audit launched on this release v1.0.12

README.md

@@ -492,15 +492,15 @@ or
 
 
 ```
-coverage : 12/04/2018
+coverage : 20/05/2018
 
-180 passing (12m)
+184 passing (10m)
 1 pending
 
 -----------------------------|----------|----------|----------|----------|----------------|
 File                         |  % Stmts | % Branch |  % Funcs |  % Lines |Uncovered Lines |
 -----------------------------|----------|----------|----------|----------|----------------|
-contracts/                  |      100 |    75.16 |      100 |      100 |                |
+contracts/                  |      100 |     74.7 |      100 |      100 |                |
 App.sol                    |      100 |       50 |      100 |      100 |                |
 AppHub.sol                 |      100 |      100 |      100 |      100 |                |
 Dataset.sol                |      100 |       50 |      100 |      100 |                |
@@ -511,17 +511,17 @@ IexecHub.sol               |      100 |    70.54 |      100 |      100 |
 IexecHubAccessor.sol       |      100 |       75 |      100 |      100 |                |
 IexecHubInterface.sol      |      100 |      100 |      100 |      100 |                |
 IexecLib.sol               |      100 |      100 |      100 |      100 |                |
-Marketplace.sol            |      100 |    88.89 |      100 |      100 |                |
+Marketplace.sol            |      100 |    83.33 |      100 |      100 |                |
 MarketplaceAccessor.sol    |      100 |       50 |      100 |      100 |                |
 MarketplaceInterface.sol   |      100 |      100 |      100 |      100 |                |
-OwnableOZ.sol              |      100 |       75 |      100 |      100 |                |
+OwnableOZ.sol              |      100 |    66.67 |      100 |      100 |                |
 SafeMathOZ.sol             |      100 |       75 |      100 |      100 |                |
 TestSha.sol                |      100 |      100 |      100 |      100 |                |
-WorkOrder.sol              |      100 |       60 |      100 |      100 |                |
-WorkerPool.sol             |      100 |    82.69 |      100 |      100 |                |
+WorkOrder.sol              |      100 |    56.25 |      100 |      100 |                |
+WorkerPool.sol             |      100 |     81.9 |      100 |      100 |                |
 WorkerPoolHub.sol          |      100 |       75 |      100 |      100 |                |
 -----------------------------|----------|----------|----------|----------|----------------|
-All files                    |      100 |    75.16 |      100 |      100 |                |
+All files                    |      100 |     74.7 |      100 |      100 |                |
 -----------------------------|----------|----------|----------|----------|----------------|
 ```
 ## Oyente analyse see [here](./oyente)

autotest.sh

@@ -75,7 +75,7 @@ function runDeploy
 	fi
 }
 
-function runTests
+function runCoreTests
 {
 	# running tests
 	for filepath in `find test/ -maxdepth 1 -type f -name "*.js" -print | sort`
@@ -99,12 +99,30 @@ function runTests
 	done
 }
 
+function runAllTests
+{
+  # running tests
+  logfile="logs/alltests.$date.log"
+  printf "Starting all test ... "
+  $TRUFFLE test > $logfile 2>&1
+  if [[ $? -ne 0 ]];
+  then
+    print_style 'danger' "failure\n"
+    print_style 'danger' "Full report is available at $logfile\n"
+    catch
+  else
+    print_style 'success' "success\n"
+    rm -f $logfile
+  fi
+}
+
 date=$(date --utc +"%Y-%m-%dT%H:%M:%S")
 checkpoint="$1"
 
 # MAIN
 initialize
 runCompile
 runDeploy
-runTests
+runCoreTests
+#runAllTests
 finalize