chore: Do some cleaning

Author: zguesmi

deploy/0_deploy.ts

@@ -181,7 +181,7 @@ export default async function deploy() {
                 rlcInstanceAddress,
                 'Staked RLC',
                 'SRLC',
-                9, // TODO: generic ?
+                9,
                 appRegistryAddress,
                 datasetRegistryAddress,
                 workerpoolRegistryAddress,

test/byContract/IexecAccessors/IexecAccessors.test.ts

@@ -209,8 +209,7 @@ describe('IexecAccessors', async () => {
         expect(contribution.weight).to.equal(1);
     });
 
-    it('viewScore', async function () {
-        // TODO
+    it.skip('[TODO] viewScore', async function () {
         expect(await iexecPoco.viewScore(worker1.address)).to.equal(0);
     });
 

test/byContract/IexecConfiguration/IexecConfiguration.test.ts

@@ -114,12 +114,12 @@ describe('IexecConfiguration', async () => {
     });
 
     describe('Import score', () => {
-        it('[TODO] Should import score', async () => {
-            // Not tested
-        });
+        it.skip('[TODO] Should import score', async () => {});
+
         it('Should not import score when no v3_iexecHub configured', async () => {
             await expect(iexecPoco.importScore(worker.address)).to.be.revertedWithoutReason();
         });
+
         it('Should not import score when already imported', async () => {
             const workerScoreImportedSlot = ethers.stripZerosLeft(
                 ethers.keccak256(

test/byContract/IexecEscrow/IexecEscrowNative.test.ts

@@ -76,7 +76,6 @@ if (config.isNativeChain()) {
             });
         });
 
-        // TODO 'Should deposit with zero value'
         describe('Deposit', () => {
             it('Should deposit native tokens', async () => {
                 expect(await iexecPocoAsAccountA.deposit.staticCall(...depositArgs)).to.be.true;
@@ -106,6 +105,16 @@ if (config.isNativeChain()) {
                     .withArgs(AddressZero, accountA.address, depositAmount);
             });
 
+            it('Should deposit amount zero', async () => {
+                expect(await iexecPocoAsAccountA.deposit.staticCall({ value: 0 })).to.be.true;
+                const tx = iexecPocoAsAccountA.deposit({ value: 0 });
+                await expect(tx).to.changeEtherBalances([accountA, iexecPoco], [0, 0]);
+                await expect(tx).to.changeTokenBalances(iexecPoco, [accountA], [0]);
+                await expect(tx)
+                    .to.emit(iexecPoco, 'Transfer')
+                    .withArgs(AddressZero, accountA.address, 0);
+            });
+
             it('Should not deposit native tokens when caller is address 0', async () => {
                 const zeroAddressSigner = await ethers.getImpersonatedSigner(ZeroAddress);
                 const iexecPocoAsAddress0 = iexecPoco.connect(zeroAddressSigner);
@@ -215,7 +224,6 @@ if (config.isNativeChain()) {
             });
         });
 
-        // TODO 'Should withdraw with zero value'
         describe('Withdraw', () => {
             it('Should withdraw native tokens', async () => {
                 await iexecPocoAsAccountA.deposit(...depositArgs);
@@ -232,6 +240,19 @@ if (config.isNativeChain()) {
                     .withArgs(accountA.address, AddressZero, withdrawAmount);
             });
 
+            it('Should withdraw amount zero', async () => {
+                await iexecPocoAsAccountA.deposit(...depositArgs);
+                expect(await iexecPocoAsAccountA.withdraw.staticCall(0)).to.be.true;
+                const tx = iexecPocoAsAccountA.withdraw(0);
+                await expect(tx).to.changeEtherBalances([accountA, iexecPoco], [0, 0]);
+                await expect(tx).to.changeTokenBalances(iexecPoco, [accountA], [0]);
+                await expect(tx)
+                    .to.emit(iexecPoco, 'Transfer')
+                    .withArgs(accountA.address, AddressZero, 0);
+                // User balance haven't changed.
+                expect(await iexecPoco.balanceOf(accountA.address)).to.equal(depositAmount);
+            });
+
             it('Should not withdraw native tokens with empty balance', async () => {
                 await expect(
                     iexecPocoAsAccountA.withdraw(...withdrawArg),

test/byContract/IexecPoco/IexecPoco2-contribute-and-finalize.test.ts

@@ -350,7 +350,7 @@ describe('IexecPoco2#contributeAndFinalize', () => {
         ).to.be.revertedWithoutReason(); // require#2
     });
 
-    it('Should not contributeAndFinalize when someone else has already contributed', async () => {
+    it.skip('[TODO] Should not contributeAndFinalize when someone else has already contributed', async () => {
         // TODO require#3
     });