Apply reviews

zguesmi · zguesmi · commit fb2876155850 · 2025-07-28T14:50:06.000+02:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,10 +3,10 @@
 ## vNEXT
 
 - Migrate proxy to Diamond pattern (ERC-2535):
-  - feat: Restore compatibility with iExec SDK. (#240)
-  - feat: Target latest EVM version (#239)
-  - refactor: Adapt contracts file tree (#238)
-  - feat: Use namespaced storage (#236, #237)
+  - Restore compatibility with iExec SDK. (#240)
+  - Target latest EVM version (#239)
+  - Adapt contracts file tree (#238)
+  - Use namespaced storage (#236, #237)
   - Format all solidity files (#233)
   - Rename ERC1538 architure to diamond Proxy architecture(#226, #229, #230, #234)
   - Remove ENS module (#225)
diff --git a/contracts/registries/Registry.sol b/contracts/registries/Registry.sol
@@ -49,6 +49,7 @@ abstract contract Registry is IRegistry, ERC721, Ownable {
      * On other chains, this function will revert to maintain retrocompatibility
      * in the SDK.
      */
+    // TODO remove this function when Bellecour is deprecated.
     function setName(address /* _ens */, string calldata /* _name */) external view onlyOwner() {
         revert("Operation not supported on this chain");
     }
diff --git a/contracts/registries/RegistryEntry.sol b/contracts/registries/RegistryEntry.sol
@@ -27,6 +27,7 @@ abstract contract RegistryEntry {
      * On other chains, this function will revert to maintain retrocompatibility
      * in the SDK.
      */
+    // TODO remove this function when Bellecour is deprecated.
     function setName(address /* _ens */, string calldata /* _name */) external view onlyOwner() {
         revert("Operation not supported on this chain");
     }

Original file line number	Diff line number	Diff line change
`@@ -49,6 +49,7 @@ abstract contract Registry is IRegistry, ERC721, Ownable {`
`49`	`49`	`* On other chains, this function will revert to maintain retrocompatibility`
`50`	`50`	`* in the SDK.`
`51`	`51`	`*/`
	`52`	`+ // TODO remove this function when Bellecour is deprecated.`
`52`	`53`	`function setName(address /* _ens /, string calldata / _name */) external view onlyOwner() {`
`53`	`54`	`revert("Operation not supported on this chain");`
`54`	`55`	`}`
Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,7 @@ abstract contract RegistryEntry {`
`27`	`27`	`* On other chains, this function will revert to maintain retrocompatibility`
`28`	`28`	`* in the SDK.`
`29`	`29`	`*/`
	`30`	`+ // TODO remove this function when Bellecour is deprecated.`
`30`	`31`	`function setName(address /* _ens /, string calldata / _name */) external view onlyOwner() {`
`31`	`32`	`revert("Operation not supported on this chain");`
`32`	`33`	`}`