fix(key-provider-agent): improve key provider agent robustness (#50)

* fix: add const to const variables

* fix: reduce scope of request_buffer

* fix: fix format

Author: aghiles-ait

cvmassistants/keyprovider/key-provider-agent/src/key_provider_agent.c

@@ -21,7 +21,7 @@ int app_log_level = LOG_LEVEL_INFO; // Default to INFO level
   do {                                                                         \
     if (app_log_level <= associated_level) {                                   \
       time_t now = time(NULL);                                                 \
-      struct tm *t = gmtime(&now);                                             \
+      const struct tm *t = gmtime(&now);                                       \
       char ts[24];                                                             \
       strftime(ts, sizeof(ts), "%Y-%m-%d %H:%M:%S UTC", t);                    \
       printf("%-29s [%-5s] [%s:%d] " fmt "\n", ts, level, __FILE__, __LINE__,  \
@@ -70,11 +70,11 @@ char *generate_random_key(void) {
 int push_wrapkey_to_secret_box(const char *wrapkey) {
   CURL *curl;
   CURLcode res;
-  char request_buffer[64];
   long http_code = 0;
 
   curl = curl_easy_init();
   if (curl) {
+    char request_buffer[64];
     // get token
     curl_easy_setopt(curl, CURLOPT_CUSTOMREQUEST, "POST");
     curl_easy_setopt(curl, CURLOPT_URL, "http://127.0.0.1:9090/secret");
@@ -147,7 +147,7 @@ int main(int argc, char **argv) {
     }
   } while (opt != -1);
 
-  char *wrap_key = generate_random_key();
+  const char *wrap_key = generate_random_key();
   if (wrap_key == NULL) {
     LOG_ERROR("Failed to generate random wrap key");
     return -1;