fix: update deployment workflow to ensure build-and-test completion and improve admin address initialization in HandlerGlobal contract

Author: Le-Caignec

.github/workflows/sharing-smart-contract-deploy.yml

@@ -30,7 +30,7 @@ jobs:
       node-version: 20
 
   deploy:
-    # needs: build-and-test
+    needs: build-and-test
     runs-on: ubuntu-latest
     env:
       CI: true
@@ -116,4 +116,4 @@ jobs:
 
       - name: Verify contracts
       # TODO
-        run: echo "Verification step is not implemented yet"
+        run: echo "Verification step is not implemented yet"

packages/sharing-smart-contract/test/invariant/handlers/HandlerGlobal.sol

@@ -24,7 +24,7 @@ contract HandlerGlobal is Test, GhostStorage {
     AddOnlyAppWhitelistRegistry public addOnlyAppWhitelistRegistry;
 
     constructor() {
-        address admin = address(54321);
+        address admin = makeAddr("admin");
         vm.label(admin, "admin");
         vm.label(address(POCO_DELEGATE), "pocoDelegate");
         vm.label(address(POCO_PROTECTED_DATA_REGISTRY), "protectedDataRegistry");
@@ -46,8 +46,6 @@ contract HandlerGlobal is Test, GhostStorage {
             Clones.clone(address(dataProtectorSharingImpl))
         );
         vm.label(address(dataProtectorSharing), "dataProtectorSharing");
-
-        vm.prank(admin);
-        dataProtectorSharing.initialize();
+        dataProtectorSharing.initialize(admin);
     }
 }