Add upgrade unit test

Author: zguesmi

packages/sharing-smart-contract/contracts/__test/DataProtectorSharingV2Mock.sol

@@ -0,0 +1,50 @@
+// SPDX-License-Identifier: Apache-2.0
+
+/******************************************************************************
+ * Copyright 2024-2025 IEXEC BLOCKCHAIN TECH                                       *
+ *                                                                            *
+ * Licensed under the Apache License, Version 2.0 (the "License");            *
+ * you may not use this file except in compliance with the License.           *
+ * You may obtain a copy of the License at                                    *
+ *                                                                            *
+ *     http://www.apache.org/licenses/LICENSE-2.0                             *
+ *                                                                            *
+ * Unless required by applicable law or agreed to in writing, software        *
+ * distributed under the License is distributed on an "AS IS" BASIS,          *
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.   *
+ * See the License for the specific language governing permissions and        *
+ * limitations under the License.                                             *
+ ******************************************************************************/
+
+pragma solidity ^0.8.24;
+
+import {ERC721BurnableUpgradeable, ERC721Upgradeable} from "@openzeppelin/contracts-upgradeable/token/ERC721/extensions/ERC721BurnableUpgradeable.sol";
+import {AccessControlUpgradeable} from "@openzeppelin/contracts-upgradeable/access/AccessControlUpgradeable.sol";
+import {Initializable} from "@openzeppelin/contracts-upgradeable/proxy/utils/Initializable.sol";
+import {MulticallUpgradeable} from "@openzeppelin/contracts-upgradeable/utils/MulticallUpgradeable.sol";
+import {ERC721Holder} from "@openzeppelin/contracts/token/ERC721/utils/ERC721Holder.sol";
+import {Math} from "@openzeppelin/contracts/utils/math/Math.sol";
+import {DataProtectorSharing} from "../DataProtectorSharing.sol";
+import {AddOnlyAppWhitelistRegistry, IAddOnlyAppWhitelist} from "../registry/AddOnlyAppWhitelistRegistry.sol";
+import {IRegistry} from "../interfaces/IRegistry.sol";
+import {ManageOrders} from "../ManageOrders.sol";
+
+/**
+ * @notice This contract is for upgradeability testing purposes only.
+ */
+
+contract DataProtectorSharingV2Mock is DataProtectorSharing {
+
+    string public newStorage;
+
+    /// @custom:oz-upgrades-unsafe-allow constructor
+    constructor() DataProtectorSharing(
+        address(0),
+        IRegistry(address(0)),
+        AddOnlyAppWhitelistRegistry(address(0))
+    ) {}
+
+    function initializeV2(string calldata foo) public reinitializer(2) {
+        newStorage = foo;
+    }
+}

packages/sharing-smart-contract/hardhat.config.cjs

@@ -2,6 +2,7 @@ require('@nomicfoundation/hardhat-foundry');
 require('@nomicfoundation/hardhat-toolbox');
 require('@openzeppelin/hardhat-upgrades');
 require('hardhat-contract-sizer');
+require('@openzeppelin/hardhat-upgrades');
 require('dotenv').config();
 
 const { WALLET_PRIVATE_KEY } = process.env;

packages/sharing-smart-contract/test/e2e/upgrade.test.js

@@ -0,0 +1,50 @@
+import { loadFixture } from '@nomicfoundation/hardhat-toolbox/network-helpers.js';
+import { expect } from 'chai';
+import hardhat from 'hardhat';
+const { ethers, upgrades } = hardhat;
+import { createCollection, deploySCFixture } from './utils/loadFixture.test.js';
+
+// TODO convert to ts.
+// TODO use typechain for factories.
+
+let dataProtectorSharingContract;
+let contractAddress;
+let owner, addr1;
+
+describe('DataProtectorSharing', function () {
+    beforeEach('Deploy fixture', async function () {
+        ({ dataProtectorSharingContract, owner, addr1 } = await loadFixture(deploySCFixture));
+        contractAddress = await dataProtectorSharingContract.getAddress();
+        await dataProtectorSharingContract.createCollection(owner).then((tx) => tx.wait());
+    });
+
+    describe('Upgrade', function () {
+        it('Should upgrade', async function () {
+            // Update the state of the original proxy.
+            const { collectionTokenId } = await createCollection();
+            // Upgrade the proxy.
+            const newImplementationFactory = await ethers.getContractFactory(
+                'DataProtectorSharingV2Mock',
+                owner,
+            );
+            await upgrades
+                .upgradeProxy(contractAddress, newImplementationFactory)
+                .then((contract) => contract.waitForDeployment());
+            const dataProtectorSharingContractV2 = await ethers.getContractAt(
+                'DataProtectorSharingV2Mock',
+                contractAddress,
+            );
+            await dataProtectorSharingContractV2.initializeV2('bar');
+            // Check V1 storage.
+            expect(await dataProtectorSharingContractV2.ownerOf(collectionTokenId)).to.equal(
+                addr1.address,
+            );
+            // Check V2 storage.
+            expect(await dataProtectorSharingContractV2.newStorage()).to.equal('bar');
+            // Check address.
+            expect(await dataProtectorSharingContractV2.getAddress()).to.equal(contractAddress);
+        });
+
+        it('TODO - Should not upgrade when storage is broken', async function () {});
+    });
+});