Skip to content

Commit 76a41cd

Browse files
committed
refactor: improve formatting of function parameters in formatGrantedAccess and update test case for clarity
1 parent 2b74d52 commit 76a41cd

File tree

2 files changed

+21
-14
lines changed

2 files changed

+21
-14
lines changed

packages/sdk/src/utils/formatGrantedAccess.ts

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,26 @@
11
import { GrantedAccess } from '../lib/types/index.js';
22

3-
export const formatGrantedAccess = (order: {
4-
dataset: string;
5-
datasetprice: number | string;
6-
volume: number | string;
7-
tag: string;
8-
apprestrict: string;
9-
workerpoolrestrict: string;
10-
requesterrestrict: string;
11-
salt: string;
12-
sign: string;
13-
}, remaining?: number): GrantedAccess => {
3+
export const formatGrantedAccess = (
4+
order: {
5+
dataset: string;
6+
datasetprice: number | string;
7+
volume: number | string;
8+
tag: string;
9+
apprestrict: string;
10+
workerpoolrestrict: string;
11+
requesterrestrict: string;
12+
salt: string;
13+
sign: string;
14+
},
15+
remaining?: number
16+
): GrantedAccess => {
1417
const formattedOrder = Object.fromEntries(
1518
Object.entries(order).map(([key, val]) => [
1619
key,
1720
val.toString().toLowerCase(),
1821
]) // stringify numbers and lowercase addresses to return a clean GrantedAccess
1922
) as Omit<GrantedAccess, 'remainingAccess'>;
20-
23+
2124
return {
2225
...formattedOrder,
2326
remainingAccess: remaining || 0,

packages/sdk/tests/unit/dataProtectorCore/revokeAllAccess.test.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -150,8 +150,12 @@ describe('dataProtectorCore.revokeAllAccess()', () => {
150150
});
151151

152152
// --- THEN
153-
const expectedDatasetOrder = formatGrantedAccess(oneDatasetOrder.order, oneDatasetOrder.remaining);
154-
const { remainingAccess, ...datasetOrderForCancel } = expectedDatasetOrder;
153+
const expectedDatasetOrder = formatGrantedAccess(
154+
oneDatasetOrder.order,
155+
oneDatasetOrder.remaining
156+
);
157+
const { remainingAccess, ...datasetOrderForCancel } =
158+
expectedDatasetOrder;
155159
expect(cancelDatasetorderMock).toHaveBeenCalledWith(
156160
datasetOrderForCancel
157161
);

0 commit comments

Comments
 (0)