Clean changes

Author: zguesmi

.github/workflows/sharing-smart-contract-test.yml

@@ -62,7 +62,6 @@ jobs:
           sarif: result.sarif
           fail-on: none
           target: 'packages/sharing-smart-contract/'
-          slither-config: 'packages/sharing-smart-contract/slither.config.json'
 
       - name: Start Anvil
         run: |

packages/sharing-smart-contract/contracts/interfaces/IPoCo.sol

@@ -29,7 +29,7 @@ interface IPoCo {
     // function deposit(uint256) external returns (bool); // Token mode
 
     // IexecERC20
-    function approve(address spender, uint256 amount) external returns (bool);
+    function approve(address spender, uint256 value) external returns (bool);
     function approveAndCall(
         address spender,
         uint256 value,
@@ -44,17 +44,17 @@ interface IPoCo {
     function allowance(address owner, address spender) external view returns (uint256);
 
     // IexecOrderManagement
-    function manageAppOrder(IexecLibOrders_v5.AppOrderOperation calldata) external;
-    function manageDatasetOrder(IexecLibOrders_v5.DatasetOrderOperation calldata) external;
-    function manageWorkerpoolOrder(IexecLibOrders_v5.WorkerpoolOrderOperation calldata) external;
-    function manageRequestOrder(IexecLibOrders_v5.RequestOrderOperation calldata) external;
+    function manageAppOrder(IexecLibOrders_v5.AppOrderOperation calldata operation) external;
+    function manageDatasetOrder(IexecLibOrders_v5.DatasetOrderOperation calldata operation) external;
+    function manageWorkerpoolOrder(IexecLibOrders_v5.WorkerpoolOrderOperation calldata operation) external;
+    function manageRequestOrder(IexecLibOrders_v5.RequestOrderOperation calldata operation) external;
 
     // IexecPoco1
     function matchOrders(
-        IexecLibOrders_v5.AppOrder calldata,
-        IexecLibOrders_v5.DatasetOrder calldata,
-        IexecLibOrders_v5.WorkerpoolOrder calldata,
-        IexecLibOrders_v5.RequestOrder calldata
+        IexecLibOrders_v5.AppOrder calldata appOrder,
+        IexecLibOrders_v5.DatasetOrder calldata datasetOrder,
+        IexecLibOrders_v5.WorkerpoolOrder calldata workerpoolOrder,
+        IexecLibOrders_v5.RequestOrder calldata requestOrder
     ) external returns (bytes32);
 }
 

packages/sharing-smart-contract/slither.config.json

@@ -1,3 +1,5 @@
+// SPDX-License-Identifier: Apache-2.0
+
 pragma solidity ^0.8.24;
 
 import {Test} from "forge-std/Test.sol";
@@ -14,7 +16,7 @@ contract SupportsInterface is Test {
 
     function setUp() external {
         _dataProtectorSharing = new DataProtectorSharing(
-            IPoCo(address(0)),
+            address(0),
             IRegistry(address(0)),
             AddOnlyAppWhitelistRegistry(address(0))
         );