Clean

Author: zguesmi

packages/sharing-smart-contract/contracts/ManageOrders.sol

@@ -38,9 +38,8 @@ abstract contract ManageOrders {
         0x0000000000000000000000000000000000000000000000000000000000000003; // [tee,scone]
     uint256 internal constant TRUST = 0; // No replication
     string internal _iexecResultStorageProvider;
-    // This value is not used anymore but it is kept
-    // as a placeholder to not break storage of the proxy
-    // deployed on Bellecour.
+    // This value is not used anymore but it must be kept
+    // to not break deployed proxies when upgrading them.
     string internal _iexecResultStorageProxy;
     uint256 private _salt;
 

packages/sharing-smart-contract/test/e2e/upgrade.test.js

@@ -29,7 +29,9 @@ describe('DataProtectorSharing', function () {
                 owner,
             );
             await upgrades
-                .upgradeProxy(contractAddress, newImplementationFactory)
+                .upgradeProxy(contractAddress, newImplementationFactory, {
+                    kind: 'transparent',
+                })
                 .then((contract) => contract.waitForDeployment());
             const dataProtectorSharingContractV2 = await ethers.getContractAt(
                 'DataProtectorSharingV2Mock',