Feat/move get result from completed task to dp core (#396)

Author: abbesBenayache

packages/sdk/CHANGELOG.md

@@ -2,6 +2,12 @@
 
 All notable changes to this project will be documented in this file.
 
+## Next
+
+### Changed
+
+- Moved `getResultFromCompletedTask` method from DataProtectorSharing module (DPS) to DataProtectorCore module (DPC).
+
 ## [2.0.0-beta.11] (2025-01-29)
 
 ### Added

packages/sdk/src/lib/dataProtectorCore/IExecDataProtectorCore.ts

@@ -10,6 +10,8 @@ import {
   ProcessProtectedDataResponse,
   ProtectDataParams,
   ProtectedData,
+  GetResultFromCompletedTaskParams,
+  GetResultFromCompletedTaskResponse,
   ProtectedDataWithSecretProps,
   RevokeAllAccessParams,
   RevokedAccess,
@@ -18,6 +20,7 @@ import {
 } from '../types/index.js';
 import { getGrantedAccess } from './getGrantedAccess.js';
 import { getProtectedData } from './getProtectedData.js';
+import { getResultFromCompletedTask } from './getResultFromCompletedTask.js';
 import { grantAccess } from './grantAccess.js';
 import { processProtectedData } from './processProtectedData.js';
 import { protectData } from './protectData.js';
@@ -84,6 +87,16 @@ class IExecDataProtectorCore extends IExecDataProtectorModule {
   ): Promise<GrantedAccessResponse> {
     return getGrantedAccess({ ...args, iexec: this.iexec });
   }
+
+  async getResultFromCompletedTask(
+    args: GetResultFromCompletedTaskParams
+  ): Promise<GetResultFromCompletedTaskResponse> {
+    await isValidProvider(this.iexec);
+    return getResultFromCompletedTask({
+      ...args,
+      iexec: this.iexec,
+    });
+  }
 }
 
 export { IExecDataProtectorCore };

…torSharing/getResultFromCompletedTask.ts …tectorCore/getResultFromCompletedTask.tspackages/sdk/src/lib/dataProtectorSharing/getResultFromCompletedTask.ts renamed to packages/sdk/src/lib/dataProtectorCore/getResultFromCompletedTask.ts packages/sdk/src/lib/dataProtectorSharing/getResultFromCompletedTask.ts renamed to packages/sdk/src/lib/dataProtectorCore/getResultFromCompletedTask.ts

@@ -22,7 +22,7 @@ import {
   validateOnStatusUpdateCallback,
 } from '../../utils/validators.js';
 import { isERC734 } from '../../utils/whitelist.js';
-import { getResultFromCompletedTask } from '../dataProtectorSharing/getResultFromCompletedTask.js';
+import { getResultFromCompletedTask } from './getResultFromCompletedTask.js';
 import {
   OnStatusUpdateFn,
   ProcessProtectedDataParams,

packages/sdk/src/lib/dataProtectorCore/processProtectedData.ts

@@ -20,8 +20,6 @@ import {
   GetProtectedDataPricingParamsResponse,
   GetRentalsParams,
   GetRentalsResponse,
-  GetResultFromCompletedTaskParams,
-  GetResultFromCompletedTaskResponse,
   GetUserAppWhitelistParams,
   GetUserAppWhitelistResponse,
   RemoveCollectionParams,
@@ -50,7 +48,6 @@ import { getCollectionSubscriptions } from './getCollectionSubscriptions.js';
 import { getProtectedDataInCollections } from './getProtectedDataInCollections.js';
 import { getProtectedDataPricingParams } from './getProtectedDataPricingParams.js';
 import { getRentals } from './getRentals.js';
-import { getResultFromCompletedTask } from './getResultFromCompletedTask.js';
 import { getUserAddOnlyAppWhitelist } from './getUserAddOnlyAppWhitelist.js';
 import { removeCollection } from './removeCollection.js';
 import { removeProtectedDataForSale } from './removeProtectedDataForSale.js';
@@ -254,16 +251,6 @@ class IExecDataProtectorSharing extends IExecDataProtectorModule {
     });
   }
 
-  async getResultFromCompletedTask(
-    args: GetResultFromCompletedTaskParams
-  ): Promise<GetResultFromCompletedTaskResponse> {
-    await isValidProvider(this.iexec);
-    return getResultFromCompletedTask({
-      ...args,
-      iexec: this.iexec,
-    });
-  }
-
   // -------------------- Apps whitelist --------------------
 
   async createAddOnlyAppWhitelist(): Promise<CreateAppWhitelistResponse> {

packages/sdk/src/lib/dataProtectorSharing/IExecDataProtectorSharing.ts

@@ -26,7 +26,7 @@ import {
   SharingContractConsumer,
 } from '../types/index.js';
 import { IExecConsumer } from '../types/internalTypes.js';
-import { getResultFromCompletedTask } from './getResultFromCompletedTask.js';
+import { getResultFromCompletedTask } from '../dataProtectorCore/getResultFromCompletedTask.js';
 import { getAppWhitelistContract } from './smartContract/getAddOnlyAppWhitelistContract.js';
 import { getSharingContract } from './smartContract/getSharingContract.js';
 import {

packages/sdk/src/lib/dataProtectorSharing/consumeProtectedData.ts

@@ -209,6 +209,23 @@ export type GrantedAccessResponse = {
   grantedAccess: GrantedAccess[];
 };
 
+// ---------------------GetResultFromCompletedTask Types------------------------------------
+
+export type GetResultFromCompletedTaskStatuses =
+  | 'CONSUME_RESULT_DOWNLOAD'
+  | 'CONSUME_RESULT_DECRYPT';
+
+export type GetResultFromCompletedTaskParams = {
+  taskId: string;
+  path?: string;
+  pemPrivateKey?: string;
+  onStatusUpdate?: OnStatusUpdateFn<GetResultFromCompletedTaskStatuses>;
+};
+
+export type GetResultFromCompletedTaskResponse = {
+  result: ArrayBuffer;
+};
+
 // ---------------------RevokeAccess Types------------------------------------
 export type RevokeAllAccessStatuses =
   | 'RETRIEVE_ALL_GRANTED_ACCESS'

packages/sdk/src/lib/types/coreTypes.ts

@@ -120,21 +120,6 @@ export type ConsumeProtectedDataResponse = {
   pemPrivateKey: string;
 };
 
-export type GetResultFromCompletedTaskStatuses =
-  | 'CONSUME_RESULT_DOWNLOAD'
-  | 'CONSUME_RESULT_DECRYPT';
-
-export type GetResultFromCompletedTaskParams = {
-  taskId: string;
-  path?: string;
-  pemPrivateKey?: string;
-  onStatusUpdate?: OnStatusUpdateFn<GetResultFromCompletedTaskStatuses>;
-};
-
-export type GetResultFromCompletedTaskResponse = {
-  result: ArrayBuffer;
-};
-
 // ---------------------Collection Types------------------------------------
 
 export type Collection = {

packages/sdk/src/lib/types/sharingTypes.ts

@@ -82,7 +82,7 @@ describe.skip('dataProtectorCore.processProtectedData()', () => {
 
       const mockArrayBuffer = new ArrayBuffer(8);
       jest.unstable_mockModule(
-        '../../../src/lib/dataProtectorSharing/getResultFromCompletedTask.js',
+        '../../../src/lib/dataProtectorCore/getResultFromCompletedTask.js',
         () => {
           return {
             getResultFromCompletedTask: jest