refactor: move My Activity button from SearcherBar to Navbar

Author: ErwanDecoster

src/components/navbar/NavBar.tsx

@@ -10,7 +10,7 @@ import { AddressChip } from './AddressChip.tsx';
 import { ChainSelector } from './ChainSelector.tsx';
 
 export function Navbar() {
-  const { isConnected, address } = useUserStore();
+  const { isConnected, address: userAddress } = useUserStore();
   const { logout, login } = useLoginLogout();
   const [isMenuOpen, setMenuOpen] = useState(false);
   const handleMenuToggle = () => {
@@ -26,6 +26,11 @@ export function Navbar() {
       <div className="mr-8 flex items-center gap-4 md:mr-0">
         {isConnected && (
           <div className="hidden md:flex">
+            <Button variant="link" asChild className="text-foreground">
+              <ChainLink to={`/address/${userAddress}?from=my_activity`}>
+                My activity
+              </ChainLink>
+            </Button>
             <Button variant="link" asChild className="text-foreground">
               <ChainLink to="/account">iExec Account</ChainLink>
             </Button>
@@ -38,7 +43,7 @@ export function Navbar() {
         </div>
         {isConnected ? (
           <div className="flex max-w-[1260px] items-center gap-2">
-            <AddressChip address={address!} />
+            <AddressChip address={userAddress!} />
 
             <button
               type="button"
@@ -81,7 +86,7 @@ export function Navbar() {
             </ChainLink>
             {isConnected ? (
               <div className="flex max-w-[1260px] items-center gap-2">
-                <AddressChip address={address!} />
+                <AddressChip address={userAddress!} />
 
                 <button
                   type="button"

src/modules/search/SearcherBar.tsx

@@ -4,7 +4,6 @@ import { useMutation } from '@tanstack/react-query';
 import { useNavigate, useParams } from '@tanstack/react-router';
 import { Search } from 'lucide-react';
 import { useEffect, useRef, useState } from 'react';
-import { ChainLink } from '@/components/ChainLink';
 import { Button } from '@/components/ui/button';
 import { Input } from '@/components/ui/input';
 import { getIExec, getReadonlyIExec } from '@/externals/iexecSdkClient';
@@ -20,7 +19,7 @@ export function SearcherBar({
   className?: string;
   initialSearch?: string;
 }) {
-  const { isConnected, address: userAddress } = useUserStore();
+  const { isConnected } = useUserStore();
   const [inputValue, setInputValue] = useState('');
   const [shake, setShake] = useState(false);
   const [errorCount, setErrorCount] = useState(0);
@@ -173,17 +172,6 @@ export function SearcherBar({
           size="18"
           className="pointer-events-none absolute top-1/2 left-4 -translate-y-1/2 sm:left-6"
         />
-        {isConnected && (
-          <Button
-            variant="outline"
-            className="bg-muted hover:bg-secondary absolute top-1/2 right-4 hidden -translate-y-1/2 sm:flex"
-            asChild
-          >
-            <ChainLink to={`/address/${userAddress}?from=my_activity`}>
-              My activity
-            </ChainLink>
-          </Button>
-        )}
       </div>
 
       <div className={cn('mt-4 flex justify-center gap-4', isError && 'mt-10')}>
@@ -192,14 +180,6 @@ export function SearcherBar({
             {isPending ? 'Searching...' : 'Search'}
           </Button>
         </div>
-
-        {isConnected && (
-          <Button variant="outline" className="sm:hidden" asChild>
-            <ChainLink to={`/address/${userAddress}?from=my_activity`}>
-              My activity
-            </ChainLink>
-          </Button>
-        )}
       </div>
     </div>
   );