Skip to content

Commit cc1f0b0

Browse files
committed
fix: improve accessibility roles in Navbar and Tabs components
1 parent b4eaf7f commit cc1f0b0

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

src/components/navbar/NavBar.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ export function Navbar() {
100100

101101
<div className="group pointer-events-none absolute inset-0 md:hidden">
102102
<label
103-
className="group/checkbox top-8.5 pointer-events-auto fixed right-6 z-30 flex size-4 origin-center transform flex-col justify-between"
103+
className="group/checkbox pointer-events-auto fixed top-8.5 right-6 z-30 flex size-4 origin-center transform flex-col justify-between"
104104
htmlFor="menu"
105105
onClick={handleMenuToggle}
106106
>
@@ -113,9 +113,9 @@ export function Navbar() {
113113
checked={isMenuOpen}
114114
readOnly
115115
/>
116-
<span className="bg-foreground w-4.5 pointer-events-none block h-0.5 origin-right transform rounded-full duration-200 group-has-[:checked]/checkbox:mt-[0.5px] group-has-[:checked]/checkbox:-rotate-45"></span>
117-
<span className="bg-foreground w-4.5 pointer-events-none block h-0.5 origin-top-right transform rounded-full duration-200 group-has-[:checked]/checkbox:scale-x-0"></span>
118-
<span className="bg-foreground w-4.5 pointer-events-none block h-0.5 origin-right transform rounded-full duration-200 group-has-[:checked]/checkbox:mb-[0.5px] group-has-[:checked]/checkbox:rotate-45"></span>
116+
<span className="bg-foreground pointer-events-none block h-0.5 w-4.5 origin-right transform rounded-full duration-200 group-has-[:checked]/checkbox:mt-[0.5px] group-has-[:checked]/checkbox:-rotate-45"></span>
117+
<span className="bg-foreground pointer-events-none block h-0.5 w-4.5 origin-top-right transform rounded-full duration-200 group-has-[:checked]/checkbox:scale-x-0"></span>
118+
<span className="bg-foreground pointer-events-none block h-0.5 w-4.5 origin-right transform rounded-full duration-200 group-has-[:checked]/checkbox:mb-[0.5px] group-has-[:checked]/checkbox:rotate-45"></span>
119119
</label>
120120

121121
<div className="border-secondary bg-background pointer-events-auto fixed inset-y-0 left-0 z-10 flex w-full -translate-x-full flex-col overflow-auto rounded-r-3xl border-r px-6 pt-6 duration-200 group-has-[:checked]:translate-x-0 lg:w-[255px] lg:translate-x-0">

src/modules/Tabs.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ export function Tabs({
6262
left: `${indicatorStyle.left}px`,
6363
width: `${indicatorStyle.width}px`,
6464
}}
65+
role="tablist"
6566
/>
6667

6768
{tabLabels.map((label, index) => {
@@ -73,7 +74,7 @@ export function Tabs({
7374
key={label}
7475
data-tab-index={index}
7576
variant="link"
76-
role="radio"
77+
role="tab"
7778
size={'none'}
7879
onClick={() => {
7980
if (!isDisabled) onTabChange(index);

0 commit comments

Comments
 (0)