fix: better address page error handling (#90)

* fix: remove NotFoundError handling and simplify error check in useAddressData

* fix: handle missing account data in useAddressData and adjust tab disabling logic

Author: ErwanDecoster

src/routes/$chainSlug/_layout/address/$addressAddress.tsx

@@ -27,7 +27,6 @@ import { AddressWorkerpoolsTable } from '@/modules/addresses/address/workerpools
 import { AddressContributionTable } from '@/modules/addresses/address/workers/beneficiaryDeals/addressContributionTable';
 import { SearcherBar } from '@/modules/search/SearcherBar';
 import useUserStore from '@/stores/useUser.store';
-import { NotFoundError } from '@/utils/NotFoundError';
 import { isValidAddress } from '@/utils/addressOrIdCheck';
 import { createPlaceholderDataFnForQueryKey } from '@/utils/createPlaceholderDataFnForQueryKey';
 
@@ -49,9 +48,24 @@ function useAddressData(address: string, chainId: number) {
           length: TABLE_LENGTH,
           address,
         });
+
         if (!result?.account) {
-          throw new NotFoundError();
+          return {
+            account: {
+              address: address,
+              allApps: [],
+              allContributions: [],
+              allDatasets: [],
+              allDealBeneficiary: [],
+              allDealRequester: [],
+              allWorkerpools: [],
+              locked: '0',
+              score: '0',
+              staked: '0',
+            },
+          };
         }
+
         return result;
       },
       refetchInterval: TABLE_REFETCH_INTERVAL,
@@ -123,24 +137,26 @@ function AddressRoute() {
   const disabledTabs: number[] = [];
   const disabledReasons: Record<number, string> = {};
 
-  // TODO like for other tab we have to check REQUESTS
+  // Only disable tabs if we have no data AND we're not loading
+  // This allows showing tabs with zero values when address exists but has no data
+  const hasAddressData = address !== null;
 
-  if (!address?.allContributions?.length) {
+  if (!isLoading && hasAddressData && !address?.allContributions?.length) {
     disabledTabs.push(2);
     disabledReasons[2] = 'No contributions for this address.';
   }
 
-  if (!address?.allApps?.length) {
+  if (!isLoading && hasAddressData && !address?.allApps?.length) {
     disabledTabs.push(3);
     disabledReasons[3] = 'No apps for this address.';
   }
 
-  if (!address?.allDatasets?.length) {
+  if (!isLoading && hasAddressData && !address?.allDatasets?.length) {
     disabledTabs.push(4);
     disabledReasons[4] = 'No datasets for this address.';
   }
 
-  if (!address?.allWorkerpools?.length) {
+  if (!isLoading && hasAddressData && !address?.allWorkerpools?.length) {
     disabledTabs.push(5);
     disabledReasons[5] = 'No workerpools for this address.';
   }
@@ -149,7 +165,7 @@ function AddressRoute() {
     return <ErrorAlert className="my-16" message="Invalid address." />;
   }
 
-  if (isError && error instanceof NotFoundError) {
+  if (isError && error && address === null) {
     return (
       <ErrorAlert className="my-16" message="No data found for this address." />
     );