refactor: improve multiaddrHexToHuman and taskResultToObject for better readability and performance

Author: ErwanDecoster

src/utils/format.ts

@@ -1,27 +1,37 @@
 import { multiaddr } from '@multiformats/multiaddr';
 
 export const multiaddrHexToHuman = (hexString: string): string => {
-  if (hexString.substring(0, 2) !== '0x') return hexString;
-  let res: string;
-  const buffer: Buffer = Buffer.from(hexString.substring(2), 'hex');
+  if (!hexString.startsWith('0x')) return hexString;
+
+  const buffer = Uint8Array.from(
+    hexString
+      .substring(2)
+      .match(/.{1,2}/g)!
+      .map((byte) => parseInt(byte, 16))
+  );
+
   try {
-    res = multiaddr(new Uint8Array(buffer)).toString();
+    return multiaddr(buffer).toString();
   } catch {
-    res = buffer.toString();
+    return new TextDecoder().decode(buffer);
   }
-  return res;
 };
 
 export const taskResultToObject = (results?: string | null) => {
   let resultObj = { storage: 'none' };
+
   try {
     if (results && results !== '0x') {
-      resultObj = JSON.parse(
-        Buffer.from(results.substring(2), 'hex').toString('utf8')
+      const hex = results.slice(2);
+      const bytes = Uint8Array.from(
+        hex.match(/.{1,2}/g)!.map((b) => parseInt(b, 16))
       );
+      const json = new TextDecoder().decode(bytes);
+      resultObj = JSON.parse(json);
     }
   } catch {
     // nothing to do
   }
+
   return resultObj;
 };